All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Liljeberg <Mika.Liljeberg@welho.com>
To: Bob Miller <rem@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: kernel BUG at /usr/src/linux-2.5.37/include/asm/spinlock.h:123!
Date: 23 Sep 2002 21:11:53 +0300	[thread overview]
Message-ID: <1032804713.6616.68.camel@devil> (raw)
In-Reply-To: <20020923084115.A17934@build.pdx.osdl.net>

On Mon, 2002-09-23 at 18:41, Bob Miller wrote:
> Mika,

Hi Bob,

> I haven't looked at the code yet... but most of the time when you see this
> error it is because the kernel is compiled with CONFIG_DEBUG_SPINLOCK and
> the code is using a lock that hasn't be initilized correctly (i.e.:
> SPIN_LOCK_UNLOCKED().

Yup. I usually compile new kernels with spinlock debugging.

Looks like a number of the ioctls in oss/audio.c have locking problems.
At least the following ones look buggy:

SNDCTL_DSP_SETTRIGGER
SNDCTL_DSP_GETIPTR
SNDCTL_DSP_GETOPTR
SNDCTL_DSP_GETODELAY

Each of these tries to manipulate a spinlock through the uninitialized
dmap pointer. SNDCTL_DSP_SETTRIGGER actually operates on both dmap_in
and dmap_out. It should presumably acquire locks for both.

Looks like a copy/paste error, probably a result of a hasty conversion
cli()/sti()'s to spinlocks.

Regards,

	MikaL

> 
> -- 
> Bob Miller					Email: rem@osdl.org
> Open Source Development Lab			Phone: 503.626.2455 Ext. 17


      reply	other threads:[~2002-09-23 18:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-22  7:25 kernel BUG at /usr/src/linux-2.5.37/include/asm/spinlock.h:123! Mika Liljeberg
2002-09-23 15:41 ` Bob Miller
2002-09-23 18:11   ` Mika Liljeberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1032804713.6616.68.camel@devil \
    --to=mika.liljeberg@welho.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rem@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.