From: Robert Love <rml@tech9.net>
To: Sylvain Pasche <sylvain_pasche@yahoo.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.41 isofs patch to avoid "bad: scheduling while atomic!"
Date: 10 Oct 2002 17:25:15 -0400 [thread overview]
Message-ID: <1034285116.795.1667.camel@phantasy> (raw)
In-Reply-To: <15781.47072.335973.295982@yahoo.fr>
On Thu, 2002-10-10 at 13:24, Sylvain Pasche wrote:
> - tmpname = (char *) __get_free_page(GFP_KERNEL);
> + tmpname = (char *) __get_free_page(GFP_KERNEL | GFP_ATOMIC);
> if (!tmpname)
> return -ENOMEM;
> tmpde = (struct iso_directory_record *) (tmpname+1024);
You just want GFP_ATOMIC, not the OR of both.
I do not see where the lock is in the call path, though. The
lock_kernel() is not counted.
I also wonder why the __might_sleep was just triggered but the
schedule() check was? Are you sure this is the culprit? By the looks
of it, I would think it is somewhere north of __might_sleep in the stack
trace.
Robert Love
next prev parent reply other threads:[~2002-10-10 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-10 17:24 2.5.41 isofs patch to avoid "bad: scheduling while atomic!" Sylvain Pasche
2002-10-10 21:25 ` Robert Love [this message]
2002-10-10 21:55 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1034285116.795.1667.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sylvain_pasche@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.