Re: what's the lockingrules for ip_conntrack_expect_list?

[Martin Josefsson <gandalf@wlug.westbo.se>]

On Sat, 2002-10-12 at 15:09, Martin Josefsson wrote:
  
> > > > ip_conntrack_expect_related
> > > > 	WRITE_LOCK(&ip_conntrack_lock);
> > > > 	LIST_FIND
> > > > 	LIST_FIND
> > > > 	list_prepend
> > 
> > This is clearly a bug, but works according to the optimization described 
> > above.  I think we should either grab the tuple_lock or at least make 
> > a verbose comment in the code describing why we don't grab it.
> 
> I'll add a read-lock on the tuple_lock here just to mark that it should
> be taken.

Oops, spoke too soon, there already exists such a comment:

         /* Because of the write lock, no reader can walk the lists,
          * so there is no need to use the tuple lock too */

I'll leave it at that.

-- 
/Martin

Never argue with an idiot. They drag you down to their level, then beat
you with experience.