From: Robert Love <rml@tech9.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
riel@conectiva.com.br
Subject: Re: [PATCH] pre-decoded wchan output
Date: 17 Oct 2002 16:04:36 -0400 [thread overview]
Message-ID: <1034885077.718.595.camel@phantasy> (raw)
In-Reply-To: <20021017205803.A7555@infradead.org>
On Thu, 2002-10-17 at 15:58, Christoph Hellwig wrote:
> Can't you just left the old, nuerical one in even if CONFIG_KALLSYMS
> ise set? One ifdef less and far less surprises..
But why? Save the call to get_wchan()...
Ideally I would like to remove the field altogether but thats too much
breakage.
A value of zero in the field position is an indication the wchan file
exists, too.
The ifdefs there do not bother me. I think its pretty clear why its
being done, although I could add a comment to the "0UL" value saying
"now in /proc/#/wchan" or whatever.
But, no, I do not agree. No human can parse /proc/#/stats anyhow.
Since procps needs to be updated for 3.0 anyhow, it will be fine.
Robert Love
next prev parent reply other threads:[~2002-10-17 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 19:14 [PATCH] pre-decoded wchan output Robert Love
2002-10-17 19:58 ` Christoph Hellwig
2002-10-17 20:04 ` Robert Love [this message]
2002-10-21 23:08 ` Pavel Machek
2002-10-26 17:44 ` Robert Love
2002-10-20 22:04 ` David =?ISO-8859-1?Q?G=F3mez=22?= <david@pleyades.net>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1034885077.718.595.camel@phantasy \
--to=rml@tech9.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.