All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Wang <chen.wang@linux.dev>
To: 葉宸佑 <chenyou910331@gmail.com>, "Hiago De Franco" <hfranco@baylibre.com>
Cc: Inochi Amaoto <inochiama@gmail.com>, sophgo@lists.linux.dev
Subject: Re: [PATCH] riscv: dts: sophgo: add cv1800b ethernet support overlay
Date: Mon, 19 Oct 2026 16:36:31 +0800	[thread overview]
Message-ID: <1036bcd5-09ce-47f0-855b-1f1fbf248825@linux.dev> (raw)
In-Reply-To: <CAKspUhL1HMT14JZARuxnoh21+mH+7_9rJRggqu_s-t4_CZB8PA@mail.gmail.com>


On 10/16/2026 10:34 AM, 葉宸佑 wrote:
> Hi Hiago, Inochi, Chen,
>
> On Wed, Oct 14, 2026 at 02:49:15PM -0300, Hiago De Franco wrote:
>> On Wed, Oct 14, 2026 at 03:56:02PM +0800, Inochi Amaoto wrote:
>>> Instead of taking this patch, I wonder whether it can be converted to a
>>> generic DT overlay file for all the supported boards, so we won't needed
>>> to merge many duplicated patch for it.
>> thanks for the idea. I can think about that, but in this case the other
>> overlay for 256M is already on linux-riscv/for-next, so after 7.4-rc1 is
>> out I can think about merging both overlays into only one file.
> Since the 256M overlay in for-next is mine, I can take the merge after
> 7.4-rc1, if that suits you.
Chen-Yu and Hiago, you two can discuss it amongst yourselves, just make 
sure there's no duplication should be fine.
>
> Only the Duo and the Duo 256M would use it: the Duo S and the Huashan
> Pi already enable gmac0 and mdio in their board files. Both labels come
> from cv180x.dtsi, so the overlay itself has nothing board-specific in
> it.
>
> What I have in mind:
>
>    1/2  turn sg2002-milkv-duo256m-eth.dtso into a shared cv18xx-eth.dtso
>    2/2  compose the same overlay with cv1800b-milkv-duo.dtb
>
> 2/2 is your patch reduced to two Makefile lines, so I would rather it
> stay yours, sent on top of 1/2 with your Duo test. If you would prefer
> to do the whole thing yourself, that is fine too, and I will test it on
> the Duo 256M.
>
> On naming, I would like to settle it in this series while the 256M
> overlay is still new. The overlay is named after what it enables, but
> the composed DTB is really the board plus the IO board: the base DTS
> already sets USB to host, which the IO board's hub needs. So I would
> call the composed DTBs sg2002-milkv-duo256m-ioboard.dtb and
> cv1800b-milkv-duo-ioboard.dtb.
>
> The reason I care about this is my own setup. Besides the IO board, I
> use the Duo 256M with Ethernet wired up without the IO board, together
> with USB networking over the USB-C port. That works on the vendor BSP,
> which uses OTG, but not on mainline: both boards are host-only today,
> and the host setting in the 256M DTS came from my own board patch,
> copied from the Duo.
>
> Once the overlay is done, I plan to look at device mode on mainline.
> If it works, the host setting could move into a usb-host overlay:
>
>    <board>-ioboard.dtb = base + eth + usb-host
>    <board>-eth.dtb     = base + eth
>
> IO board users would then see no change. If the composed DTB kept the
> -eth name instead, it would silently lose the IO board's USB ports when
> the base changes, which is why I would rather rename now. That part
> would be a separate series, of course.
>
> I have both setups here, so please feel free to Cc me on Milk-V Duo
> patches; I am glad to test.
>
> Inochi, Chen, does that layout make sense to you, and any preference
> on the names?

Are there many expansion I/O boards currently on the market for the Duo 
series? I'm not entirely sure, but my suggestion would be to avoid 
adding too much support for expansion boards to the main codebase, 
that's something best left for others to implement offline.

Inochi, what do you think?

> Thanks,
> Chen-Yu

Thanks, Chen



      reply	other threads:[~2026-10-19  8:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 19:38 [PATCH] riscv: dts: sophgo: add cv1800b ethernet support overlay Hiago De Franco
2026-10-01 19:38 ` Hiago De Franco
2026-10-02  3:49 ` 葉宸佑
2026-10-02  3:49   ` 葉宸佑
2026-10-14  0:35 ` Hiago De Franco
2026-10-14  0:35   ` Hiago De Franco
2026-10-14  2:37   ` Chen Wang
2026-10-14  7:56     ` Inochi Amaoto
2026-10-14 17:49       ` Hiago De Franco
2026-10-16  2:34         ` 葉宸佑
2026-10-19  8:36           ` Chen Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1036bcd5-09ce-47f0-855b-1f1fbf248825@linux.dev \
    --to=chen.wang@linux.dev \
    --cc=chenyou910331@gmail.com \
    --cc=hfranco@baylibre.com \
    --cc=inochiama@gmail.com \
    --cc=sophgo@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.