From: Gianni Tedesco <gianni@ecsc.co.uk>
To: Harald Welte <laforge@gnumonks.org>
Cc: netfilter-devel@lists.samba.org
Subject: [PATCH]: NETLINK can sleep in illegal context
Date: 11 Nov 2002 10:14:24 +0000 [thread overview]
Message-ID: <1037009663.29603.5.camel@lemsip> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 448 bytes --]
Hello,
Attached patch fixes kernel panic in the NETLINK target. It's quite rare
(I run this on about 100 firewalls and have seen it happen on 1 so far).
Its just a GFP_KERNEL where it needs to be a GFP_ATOMIC.
*hangs head in shame at such a lame bug*
--
// Gianni Tedesco (gianni at ecsc dot co dot uk)
lynx --source www.scaramanga.co.uk/gianni-at-ecsc.asc | gpg --import
8646BE7D: 6D9F 2287 870E A2C9 8F60 3A3C 91B5 7669 8646 BE7D
[-- Attachment #1.2: NETLINK-illegal-context.diff --]
[-- Type: text/x-patch, Size: 585 bytes --]
diff -u -r1.3 NETLINK.patch
--- netfilter.orig/patch-o-matic/base/NETLINK.patch 12 Nov 2001 08:19:29 -0000 1.3
+++ netfilter/patch-o-matic/base/NETLINK.patch 11 Nov 2002 10:10:22 -0000
@@ -65,7 +65,7 @@
+ skb_put(outskb, len);
+ memcpy(outskb->data, &nlhdr, sizeof(nlhdr));
+ memcpy((outskb->data)+sizeof(nlhdr), ip, len-sizeof(nlhdr));
-+ netlink_broadcast(ipfwsk, outskb, 0, ~0, GFP_KERNEL);
++ netlink_broadcast(ipfwsk, outskb, 0, ~0, GFP_ATOMIC);
+ }else{
+ if (net_ratelimit())
+ printk(KERN_WARNING "ipt_NETLINK: packet drop due to netlink failure\n");
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 232 bytes --]
reply other threads:[~2002-11-11 10:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1037009663.29603.5.camel@lemsip \
--to=gianni@ecsc.co.uk \
--cc=laforge@gnumonks.org \
--cc=netfilter-devel@lists.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.