Re: Oops with in nfsd - 2.4.19-pre6

[Chris Mason <mason@suse.com>]

On Wed, 2002-11-13 at 13:40, Philippe Gramoullé wrote:
> On 13 Nov 2002 13:14:18 -0500
> Chris Mason <mason@suse.com> wrote:
> 
>   |  Ok, I was hoping for some confirmation that you've seen the bug fixed
>   |   with the quota code.  Which kernel version + list of patches are you
>   |   best able to test on?  I'll make you patch against that.
>   |  
>   |   -chris
> 
> Unfortunately, we hit the bug again this afternoon :-(
> 
> We use to have 2.4.19-pre6 with the quota patches from
> ftp.suse.com:/pub/people/mason/patches/reiserfs/quota-2.4/2.4.19
> ( 0xFFFF test removed in sys_quotactl() in fs/dquot.c to support 32 bit UIDS)
> and IIRC NFS_ALL patch for 2.4.19
> 
> Being unable to run the quota anyway with 2.4.19-pre6,as it would make the filer crash, i upgraded to
> 2.4.20rc1 + data-logging patches and mounted the fs witn noatime,nodiratime and data=journal

Ok, I'll make a patch against that.

> 
> Filer is still heavily loaded but runs fine. Problem now is that we don't have quota working anymore
> and this is a _big_ issue as warez lovers do test our systems every single minute.
> 
> BTW, should i apply the patch posted on LKML ?
> Subject:2.[45] fixes for design locking bug in wait_on_page/wait_on_buffer/get_request_wait

No, wait for that fix to get into a kernel before using it.  There might
still be small modifications, and andrea might find a few other places
in the kernel with similar races.

The bug results in io stalls, and the machines that do see them stall
for between 10 minutes and an hour.  If you needed the patch you would
have already been complaining ;-)  The races do not cause corruptions or
crashes of any kind.

> 
> Ideally, i'd like to stay with 2.4.20rc1 thus having working quota.
> I couldn't check closely enough because of being too busy but i think many important patches have been
> set into RC1 (new block allocator, etc..).
> I tried to have a look to merge the quota code with RC1 but unfortunately my knowledge of quota/reiserfs
> prevent me from doing anything but cosmetic merge :o)
> 
> Let me know what are you plans.

Jan and I will get an updated quota patch asap, and I'll have my
attempted fix for the transaction overflow ready for you against that
set of patches in a few hours.

-chris