All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@redhat.com>
To: Marc-Christian Petersen <m.c.p@wolk-project.de>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Arjan van de Ven <arjan@nl.linux.org>
Subject: Re: [BUG] 2.4.20-rc2-ac3 oops (causer is DRM 4.3.x code)
Date: 25 Nov 2002 18:02:27 +0100	[thread overview]
Message-ID: <1038243747.1372.0.camel@localhost.localdomain> (raw)
In-Reply-To: <200211251711.59882.m.c.p@wolk-project.de>

On Mon, 2002-11-25 at 17:12, Marc-Christian Petersen wrote:
> Hi Alan, Hi Arjan,
> 

@ -622,16 +615,20 @@
        if ( dev->dev_private ) {
                drm_r128_private_t *dev_priv = dev->dev_private;

+#if __REALLY_HAVE_SG
                if ( !dev_priv->is_pci ) {
+#endif
                        DRM_IOREMAPFREE( dev_priv->cce_ring );
                        DRM_IOREMAPFREE( dev_priv->ring_rptr );
                        DRM_IOREMAPFREE( dev_priv->buffers );
+#if __REALLY_HAVE_SG
                } else {
                        if (!DRM(ati_pcigart_cleanup)( dev,
                                                dev_priv->phys_pci_gart,
                                                dev_priv->bus_pci_gart
))
                                DRM_ERROR( "failed to cleanup PCI
GART!\n" );
                }
+#endif
 

is the only worthy change to drivers/char/drm/r128_cce.c that I can
think of that can cause this, could you try to just remove the #if's ?

  reply	other threads:[~2002-11-25 16:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-25 16:12 [BUG] 2.4.20-rc2-ac3 oops (causer is DRM 4.3.x code) Marc-Christian Petersen
2002-11-25 17:02 ` Arjan van de Ven [this message]
2002-11-25 17:12   ` Marc-Christian Petersen
2002-11-25 20:14     ` Marc-Christian Petersen
2002-11-25 20:27       ` Marc-Christian Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1038243747.1372.0.camel@localhost.localdomain \
    --to=arjanv@redhat.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjan@nl.linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.c.p@wolk-project.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.