All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <mason@suse.com>
To: Andrew Morton <akpm@digeo.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	"ext3-users@redhat.com" <ext3-users@redhat.com>
Subject: Re: [patch] fix the ext3 data=journal unmount bug
Date: 06 Dec 2002 13:02:49 -0500	[thread overview]
Message-ID: <1039197769.7939.46.camel@tiny> (raw)
In-Reply-To: <3DF03B35.AA5858DC@digeo.com>

On Fri, 2002-12-06 at 00:52, Andrew Morton wrote:
> 
> 
> This patch fixes the data loss which can occur when unmounting a
> data=journal ext3 filesystem.
> 
> The core problem is that the VFS doesn't tell the filesystem enough
> about what is happening.  ext3 _needs_ to know the difference between
> regular memory-cleansing writeback and sync-for-data-integrity
> purposes.
> 

What happens when the user does a sync() immediately after kupdate
trigger a write_super?

Since ext3_write_super just clears s_dirt, I don't see how sync_fs()
will get called.

-chris
 


  reply	other threads:[~2002-12-06 17:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-06  5:52 [patch] fix the ext3 data=journal unmount bug Andrew Morton
2002-12-06 18:02 ` Chris Mason [this message]
2002-12-06 19:12   ` Andrew Morton
2002-12-06 19:34     ` Chris Mason
2002-12-06 19:45       ` Andrew Morton
2002-12-06 19:57         ` Stephen C. Tweedie
2002-12-06 20:34           ` Chris Mason
2002-12-06 21:22             ` Stephen C. Tweedie
2002-12-06 22:07               ` Chris Mason
2002-12-06 22:25                 ` Stephen C. Tweedie
2002-12-07 14:54 ` Matthias Andree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1039197769.7939.46.camel@tiny \
    --to=mason@suse.com \
    --cc=akpm@digeo.com \
    --cc=ext3-users@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.