From: Robert Love <rml@tech9.net>
To: george anzinger <george@mvista.com>
Cc: Arjan van de Ven <arjanv@redhat.com>,
Linus Torvalds <torvalds@transmeta.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] High-res-timers part 1 (core) take 20
Date: 09 Dec 2002 03:21:55 -0500 [thread overview]
Message-ID: <1039422115.15169.7.camel@phantasy> (raw)
In-Reply-To: <3DF44031.58A12F66@mvista.com>
On Mon, 2002-12-09 at 02:03, george anzinger wrote:
> > > + IF_SMP(if (old_base && (new_base != old_base))
> > > + spin_unlock(&old_base->lock);
> > > + )
> >
> > Like here..... SMP dependent ifdef's of spinlock usage... shudder
> >
> Well it does seem like a waste to do spinlock ordering code
> on a UP system...
Well the spin locks will compile away if !CONFIG_SMP, and then the
compiler will remove the empty branch.
But this is not just cleanliness: doesn't this evade the
preempt_disable() in the spin_unlock() on !CONFIG_SMP+CONFIG_PREEMPT?
Robert Love
next prev parent reply other threads:[~2002-12-09 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-08 7:46 [PATCH 1/3] High-res-timers part 1 (core) take 20 george anzinger
2002-12-08 9:50 ` Arjan van de Ven
2002-12-09 7:03 ` george anzinger
2002-12-09 8:21 ` Robert Love [this message]
2002-12-09 8:53 ` Arjan van de Ven
2002-12-09 12:27 ` george anzinger
2002-12-09 12:34 ` Arjan van de Ven
2002-12-10 6:55 ` george anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1039422115.15169.7.camel@phantasy \
--to=rml@tech9.net \
--cc=arjanv@redhat.com \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.