From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] remove error message on illegal ioctl
Date: 13 Dec 2002 21:22:22 -0500 [thread overview]
Message-ID: <1039832542.5305.455.camel@phantasy> (raw)
This error message is uber annoying and needs to go. Non-root can flood
the console with this junk on invalid SCSI CD-ROM ioctl(),
and that is exactly what gnome-cd does.
An illegal ioctl() returns an error to the program. That is
sufficient - we do not need KERN_ERROR warnings all over the place.
Especially when any user can cause them at any rate.
This patch, against 2.5.51, removes the message. Linus, please
apply.
Robert Love
drivers/scsi/sr_ioctl.c | 3 ---
1 files changed, 3 deletions(-)
diff -urN linux-2.5.51/drivers/scsi/sr_ioctl.c linux/drivers/scsi/sr_ioctl.c
--- linux-2.5.51/drivers/scsi/sr_ioctl.c 2002-12-10 17:45:03.000000000 -0500
+++ linux/drivers/scsi/sr_ioctl.c 2002-12-11 00:44:24.000000000 -0500
@@ -156,9 +156,6 @@
err = -ENOMEDIUM;
break;
case ILLEGAL_REQUEST:
- if (!cgc->quiet)
- printk(KERN_ERR "%s: CDROM (ioctl) reports ILLEGAL "
- "REQUEST.\n", cd->cdi.name);
err = -EIO;
if (SRpnt->sr_sense_buffer[12] == 0x20 &&
SRpnt->sr_sense_buffer[13] == 0x00)
next reply other threads:[~2002-12-14 2:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-14 2:22 Robert Love [this message]
2002-12-16 9:16 ` [PATCH] remove error message on illegal ioctl Jens Axboe
2002-12-16 9:39 ` Linus Torvalds
2002-12-16 11:56 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2002-12-11 5:56 Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1039832542.5305.455.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.