From: Chris Mason <mason@suse.com>
To: Oleg Drokin <green@namesys.com>
Cc: Andrew Morton <akpm@digeo.com>, Hans Reiser <reiser@namesys.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BK][PATCH] ReiserFS CPU and memory bandwidth efficient large writes
Date: 16 Dec 2002 13:24:28 -0500 [thread overview]
Message-ID: <1040063068.17501.31.camel@tiny> (raw)
In-Reply-To: <20021214232520.A10786@namesys.com>
On Sat, 2002-12-14 at 15:25, Oleg Drokin wrote:
> reiserfs v3 was traditionally hungry on stack space I think.
Well, if you want to drop stack usage, kill some inlines from stree.c.
I really doubt we gain anything from inlining these:
--- linux/fs/reiserfs/stree.c.1 Tue Sep 24 09:50:50 2002
+++ linux/fs/reiserfs/stree.c Tue Sep 24 09:51:18 2002
@@ -340,7 +340,7 @@
/* Get delimiting key of the buffer at the path and its right neighbor. */
-inline const struct key * get_rkey (
+const struct key * get_rkey (
const struct path * p_s_chk_path,
const struct super_block * p_s_sb
) {
@@ -925,7 +925,7 @@
// prepare for delete or cut of direct item
-static inline int prepare_for_direct_item (struct path * path,
+static int prepare_for_direct_item (struct path * path,
struct item_head * le_ih,
struct inode * inode,
loff_t new_file_length,
@@ -970,7 +970,7 @@
}
-static inline int prepare_for_direntry_item (struct path * path,
+static int prepare_for_direntry_item (struct path * path,
struct item_head * le_ih,
struct inode * inode,
loff_t new_file_length,
next prev parent reply other threads:[~2002-12-16 18:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-13 18:56 [BK][PATCH] ReiserFS CPU and memory bandwidth efficient large writes Hans Reiser
2002-12-13 21:40 ` Andrew Morton
2002-12-14 1:11 ` Hans Reiser
2002-12-14 11:44 ` Oleg Drokin
2002-12-14 18:27 ` Andrew Morton
2002-12-14 13:21 ` Oleg Drokin
2002-12-14 18:42 ` Andrew Morton
2002-12-14 19:20 ` Oleg Drokin
2002-12-14 20:10 ` Andrew Morton
2002-12-14 20:25 ` Oleg Drokin
2002-12-16 18:24 ` Chris Mason [this message]
2002-12-17 10:53 ` Oleg Drokin
2002-12-14 22:21 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1040063068.17501.31.camel@tiny \
--to=mason@suse.com \
--cc=akpm@digeo.com \
--cc=green@namesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiser@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.