All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: "Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@intel.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: RE: [PATCH 2.5.52] Use __set_current_state() instead of current-> state = (take 1)
Date: 18 Dec 2002 22:19:47 -0500	[thread overview]
Message-ID: <1040267987.848.130.camel@phantasy> (raw)
In-Reply-To: <A46BBDB345A7D5118EC90002A5072C7806CACA30@orsmsx116.jf.intel.com>

On Wed, 2002-12-18 at 21:40, Perez-Gonzalez, Inaky wrote:

> Well, I think it makes kind of sense. If we know we are
> returning to some place where nothing bad could happen
> with reordering ... well, so be it, don't use __set_...()

Oh, I see.  If it returns to somewhere that immediately e.g. puts it on
a wait queue.  In that case, yep: need the barrier version.

> And that would now really work when CONFIG_X86_OOSTORE=1 is required
> [after all, it is a write, so it'd need the equivalent of a wmb() or
> xchg()].

Is this a hint that your employer may have an x86 chip in the future
with weak ordering? :)

> Okay, changing that one too, just in case.

Good - better safe than sorry.

	Robert Love


  reply	other threads:[~2002-12-19  3:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-19  2:40 [PATCH 2.5.52] Use __set_current_state() instead of current-> state = (take 1) Perez-Gonzalez, Inaky
2002-12-19  3:19 ` Robert Love [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-12-19 19:04 Perez-Gonzalez, Inaky
2002-12-20  3:08 ` Alan Cox
2002-12-20 19:36   ` Oliver Xymoron
2002-12-19  1:53 Perez-Gonzalez, Inaky
2002-12-19  2:04 ` Robert Love
2002-12-19  0:46 Perez-Gonzalez, Inaky
2002-12-19  1:03 ` Robert Love
2002-12-18 23:56 [PATCH 2.5.52] Use __set_current_state() instead of current->state " Inaky Perez-Gonzalez
2002-12-19  0:11 ` Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1040267987.848.130.camel@phantasy \
    --to=rml@tech9.net \
    --cc=inaky.perez-gonzalez@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.