From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v5 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings Date: Thu, 11 Jul 2019 23:28:14 +0200 Message-ID: <10427933.3dknIRnSiX@diego> References: <20190401171724.215780-1-dianders@chromium.org> <20190401171724.215780-8-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190401171724.215780-8-dianders@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Douglas Anderson Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Thierry Reding , Sean Paul , Laurent Pinchart , Boris Brezillon , Enric =?ISO-8859-1?Q?Balletb=F2?= , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org QW0gTW9udGFnLCAxLiBBcHJpbCAyMDE5LCAxOToxNzoyNCBDRVNUIHNjaHJpZWIgRG91Z2xhcyBB bmRlcnNvbjoKPiBKdXN0IGxpa2Ugd2UgZGlkIGZvciByazMyODgtdmV5cm9uLWNocm9tZWJvb2ss IHdlIHdhbnQgdG8gYmUgYWJsZSB0bwo+IHVzZSBvbmUgb2YgdGhlIGZpeGVkIFBMTHMgaW4gdGhl IHN5c3RlbSB0byBtYWtlIHRoZSBwaXhlbCBjbG9jayBmb3IKPiBtaW5uaWUuCj4gCj4gU3BlY2lm eWluZyB0aGVzZSB0aW1pbmdzIG1hdGNoZXMgdXMgd2l0aCBob3cgdGhlIGRpc3BsYXkgaXMgdXNl ZCBvbgo+IHRoZSBkb3duc3RyZWFtIENocm9tZSBPUyBrZXJuZWwuICBTZWUgaHR0cHM6Ly9jcnJl di5jb20vYy8zMjMyMTEuCj4gCj4gVW5saWtlIHdoYXQgd2UgZGlkIGZvciByazMyODgtdmV5cm9u LWNocm9tZWJvb2ssIHRoaXMgQ0wgYWN0dWFsbHkKPiBjaGFuZ2VzIHRoZSB0aW1pbmdzICh0aG91 Z2ggbm90IHRoZSBwaXhlbCBjbG9jaykgdGhhdCBpcyB1c2VkIHdoZW4KPiB1c2luZyB0aGUgdXBz dHJlYW0ga2VybmVsLiAgQm9vdGluZyB1cCBhIG1pbm5pZSBzaG93cyB0aGF0IGl0IGVuZGVkIHVw Cj4gd2l0aCBhIDY2LjY3IE1IeiBwaXhlbCBjbG9jayBidXQgaXQgd2FzIHN0aWxsIHVzaW5nIHRo ZQo+IHBvcmNoZXMvYmxhbmtpbmdzIGl0IHdvdWxkIGhhdmUgd2FudGVkIGZvciBhIDcyLjUgTUh6 IHBpeGVsIGNsb2NrLgo+IAo+IE5PVEU6IGNvbXBhcmVkIHRvIHRoZSBkb3duc3RyZWFtIGtlcm5l bCwgdGhpcyBzZWVtcyB0byBjYXVzZSBhCj4gc2xpZ2h0bHkgZGlmZmVyZW50IHJlc3VsdCByZXBv cnRlZCBpbiB0aGUgJ21vZGV0ZXN0JyBjb21tYW5kIG9uIGEKPiBDaHJvbWVib29rLiAgVGhlIGRv d25zdHJlYW0ga2VybmVsIHNob3dzOgo+ICAgMTI4MHg4MDAgNjAgMTI4MCAxMjk4IDEzMzAgMTM1 MSA4MDAgODA0IDgyMiA4MzAgNjY2NjcKPiAKPiBXaXRoIHRoaXMgcGF0Y2ggd2UgaGF2ZToKPiAg IDEyODB4ODAwIDU5IDEyODAgMTI5OCAxMzMwIDEzNTEgODAwIDgwNCA4MjIgODMwIDY2NjY2Cj4g Cj4gU3BlY2lmaWNhbGx5IG1vZGV0ZXN0IHdhcyByZXBvcnRpbmcgNjAgSHogb24gdGhlIGRvd25z dHJlYW0ga2VybmVsIGJ1dAo+IHRoZSB1cHN0cmVhbSBrZXJuZWwgZG9lcyB0aGUgbWF0aCBhbmQg Y29tZXN1cCB3aXRoIDU5IChiZWNhdXNlIHdlCj4gYWN0dWFsbHkgYWNoaWV2ZSA1OS40NSBIeiku ICBBbHNvIHVwc3RyZWFtIGRvZXNuJ3Qgcm91bmQgdGhlIEh6IHVwCj4gd2hlbiBjb252ZXJ0aW5n IHRvIGtIei0taXQgc2VlbXMgdG8gdHJ1bmNhdGUuCj4gCj4gQUxTTyBOT1RFOiB3aGVuIEkgbG9v ayBhdCB0aGUgRURJRCBmcm9tIHRoZSBkYXRhc2hlZXQsIEkgc2VlOgo+ICAgLWhzeW5jIC12c3lu Ywo+IC4uLmJ1dCBpdCBzZWVtcyBsaWtlIHdlJ3ZlIG5ldmVyIGFjdHVhbGx5IHJ1biB3aXRoIHRo YXQgc28gSSd2ZQo+IGNvbnRpbnVlZCBsZWF2aW5nIHRoYXQgb3V0Lgo+IAo+IFNpZ25lZC1vZmYt Ynk6IERvdWdsYXMgQW5kZXJzb24gPGRpYW5kZXJzQGNocm9taXVtLm9yZz4KCmFwcGxpZWQgZm9y IDUuNAoKVGhhbmtzCkhlaWtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3218C742A2 for ; Thu, 11 Jul 2019 21:28:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4CDD208E4 for ; Thu, 11 Jul 2019 21:28:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mheRP4YO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4CDD208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MklMBlBNLs0MLGA5XEEsfacAobkBoh1t0IbB1k2UatQ=; b=mheRP4YOahCAqz lSzG4icGBwRlh7rBJoxq9m1CHpt7wdEiyVEJcJa5sRJswiZ9w/nuR6L4RiaoC9OnwixiZtbO5led6 QKxYxlWyG+Lbpdi2Z5XkSFi8WVEYlbB/Ks1e/vQyAVmD1fe4jlxfktbiZKoz5rf2Toro04zv1jSXT RICywGdF/f/ycpzarvITqn8dgNXkSsh9DxDrWDFJhRFNe2/ICeggRDUhWP3CSB1Msj3kJSFcebKVW qS7mMiViesv8j7g0sB9E+2Cnnx2HbE8WsoBpSSrDUzVmlw9cgMeaYBQk1tnyhk5/4ZT4KeovldvOb k32xJlGhAHNah5hLH7aQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hlgc5-0004Li-2o; Thu, 11 Jul 2019 21:28:25 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hlgbz-0004F4-Pt; Thu, 11 Jul 2019 21:28:21 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlgbu-0006n4-SN; Thu, 11 Jul 2019 23:28:14 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Douglas Anderson Subject: Re: [PATCH v5 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings Date: Thu, 11 Jul 2019 23:28:14 +0200 Message-ID: <10427933.3dknIRnSiX@diego> In-Reply-To: <20190401171724.215780-8-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> <20190401171724.215780-8-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190711_142820_004032_20927844 X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Thierry Reding , Sean Paul , Laurent Pinchart , Boris Brezillon , Enric =?ISO-8859-1?Q?Balletb=F2?= , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 1. April 2019, 19:17:24 CEST schrieb Douglas Anderson: > Just like we did for rk3288-veyron-chromebook, we want to be able to > use one of the fixed PLLs in the system to make the pixel clock for > minnie. > > Specifying these timings matches us with how the display is used on > the downstream Chrome OS kernel. See https://crrev.com/c/323211. > > Unlike what we did for rk3288-veyron-chromebook, this CL actually > changes the timings (though not the pixel clock) that is used when > using the upstream kernel. Booting up a minnie shows that it ended up > with a 66.67 MHz pixel clock but it was still using the > porches/blankings it would have wanted for a 72.5 MHz pixel clock. > > NOTE: compared to the downstream kernel, this seems to cause a > slightly different result reported in the 'modetest' command on a > Chromebook. The downstream kernel shows: > 1280x800 60 1280 1298 1330 1351 800 804 822 830 66667 > > With this patch we have: > 1280x800 59 1280 1298 1330 1351 800 804 822 830 66666 > > Specifically modetest was reporting 60 Hz on the downstream kernel but > the upstream kernel does the math and comesup with 59 (because we > actually achieve 59.45 Hz). Also upstream doesn't round the Hz up > when converting to kHz--it seems to truncate. > > ALSO NOTE: when I look at the EDID from the datasheet, I see: > -hsync -vsync > ...but it seems like we've never actually run with that so I've > continued leaving that out. > > Signed-off-by: Douglas Anderson applied for 5.4 Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5788DC742A1 for ; Thu, 11 Jul 2019 21:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FC3D21019 for ; Thu, 11 Jul 2019 21:28:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728877AbfGKV2T (ORCPT ); Thu, 11 Jul 2019 17:28:19 -0400 Received: from gloria.sntech.de ([185.11.138.130]:36214 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfGKV2T (ORCPT ); Thu, 11 Jul 2019 17:28:19 -0400 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlgbu-0006n4-SN; Thu, 11 Jul 2019 23:28:14 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Douglas Anderson Cc: Thierry Reding , Sean Paul , linux-rockchip@lists.infradead.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, Boris Brezillon , Ezequiel Garcia , Enric =?ISO-8859-1?Q?Balletb=F2?= , Rob Herring , mka@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings Date: Thu, 11 Jul 2019 23:28:14 +0200 Message-ID: <10427933.3dknIRnSiX@diego> In-Reply-To: <20190401171724.215780-8-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> <20190401171724.215780-8-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 1. April 2019, 19:17:24 CEST schrieb Douglas Anderson: > Just like we did for rk3288-veyron-chromebook, we want to be able to > use one of the fixed PLLs in the system to make the pixel clock for > minnie. > > Specifying these timings matches us with how the display is used on > the downstream Chrome OS kernel. See https://crrev.com/c/323211. > > Unlike what we did for rk3288-veyron-chromebook, this CL actually > changes the timings (though not the pixel clock) that is used when > using the upstream kernel. Booting up a minnie shows that it ended up > with a 66.67 MHz pixel clock but it was still using the > porches/blankings it would have wanted for a 72.5 MHz pixel clock. > > NOTE: compared to the downstream kernel, this seems to cause a > slightly different result reported in the 'modetest' command on a > Chromebook. The downstream kernel shows: > 1280x800 60 1280 1298 1330 1351 800 804 822 830 66667 > > With this patch we have: > 1280x800 59 1280 1298 1330 1351 800 804 822 830 66666 > > Specifically modetest was reporting 60 Hz on the downstream kernel but > the upstream kernel does the math and comesup with 59 (because we > actually achieve 59.45 Hz). Also upstream doesn't round the Hz up > when converting to kHz--it seems to truncate. > > ALSO NOTE: when I look at the EDID from the datasheet, I see: > -hsync -vsync > ...but it seems like we've never actually run with that so I've > continued leaving that out. > > Signed-off-by: Douglas Anderson applied for 5.4 Thanks Heiko