All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jérôme Pouiller" <jezz@sysmic.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra: Add a way to apply patches using git
Date: Mon, 03 Nov 2014 16:01:57 +0100	[thread overview]
Message-ID: <10430487.gOJDMNlg1N@aquila> (raw)
In-Reply-To: <20141101231125.2ca351ca@free-electrons.com>

On Saturday 01 November 2014 23:11:25 Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle,
> 
> On Sat, 01 Nov 2014 23:06:23 +0100, Arnout Vandecappelle wrote:
> > > We discussed this proposal at the last Buildroot Developers meeting.
> > > Even though we understand the idea and some of us found it potentially
> > > interesting, we didn't really like the implementation, but nobody
> > > really found a way of implementing something like this in a nice way.
> > > 
> > > One of the problem is that not all our patches are Git patches, which
> > > you had to work-around in your patch in a way that isn't really nice.
> > > 
> > > Maybe Arnout and Yann (in Cc) remember more of the issues that we
> > > discussed at the meeting regarding this proposal.
> >  
> >  For simple patches, a simple diff is normally sufficient. For more
> >  complicated> 
> > stuff, it is really worthwhile to clone the upstream repository and work
> > from there - you'll anyway need to do that to upstream the patches.
> > 
> >  So we felt that the need for this feature did not outweigh the complexity
> >  of> 
> > its implementation.
>
> Ah yes, right: we thought that having a Git repository that isn't the
> one from upstream made it unpractical to submit patches back to
> upstream, and was making the entire feature a bit useless.
I also worried about this restriction. My first idea was to recreate the link 
between source directory and upstream repository with something like:

   cd $PKG_BUILD_DIR
   git clone $PKG_SITE --bare .git
   git config --bool core.bare false
   git rev-parse $PKG_VERSION > .git/HEAD
   git reset

However, my patch began to smell black magic. 


Ideally, I wanted to create an external tool to do this. However, it is not 
easy to integrate an external tool with Makefile system (For example, I did 
not found any handy way to get variables associated with package).


If anyone have ideas about this subject, I would be happy to work on and 
resubmit a patch.


-- 
J?r?me Pouiller, Sysmic

  reply	other threads:[~2014-11-03 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 17:20 [Buildroot] [PATCH] infra: Add a way to apply patches using git Jérôme Pouiller
2014-11-01 21:47 ` Thomas Petazzoni
2014-11-01 22:06   ` Arnout Vandecappelle
2014-11-01 22:11     ` Thomas Petazzoni
2014-11-03 15:01       ` Jérôme Pouiller [this message]
2014-11-03 20:21         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10430487.gOJDMNlg1N@aquila \
    --to=jezz@sysmic.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.