From: Chris Mason <mason@suse.com>
To: John Dalbec <jpdalbec@ysu.edu>
Cc: reiserfs-list@namesys.com
Subject: Re: Trying to port data-logging to RH 2.4.18-19.7.x kernel
Date: 03 Feb 2003 11:41:49 -0500 [thread overview]
Message-ID: <1044290509.15685.391.camel@tiny.suse.com> (raw)
In-Reply-To: <3E3AEA73.1090607@ysu.edu>
On Fri, 2003-01-31 at 16:28, John Dalbec wrote:
> The immediate caller is the "ReiserFS specific hack" in
> fs/inode.c:get_inode signed <mason@suse.com>. Is the BKL supposed to be
> held when get_inode is called?
Traditionally, the BKL is supposed to be held when iget or iget4 is
called. RedHat might have patches that do away with that and simply
missed reiserfs, but it is more likely they have a patch to reduce BKL
use in NFS that missed the iget4 case.
So your two basic choices are adding the BKL to reiserfs_read_inode2, or
going into the nfsd source and putting them around the iget4 call. You
might want to double check to see if their source had the BKL in
reiserfs_read_inode2 before you started the data logging port.
If not, you should be able to reproduce the oops on an unmodified redhat
kernel (compiled with SMP on), and I'd appreciate it if you could send
them a bug report as well.
-chris
next prev parent reply other threads:[~2003-02-03 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-31 14:41 Trying to port data-logging to RH 2.4.18-19.7.x kernel John Dalbec
2003-01-31 14:55 ` Chris Mason
2003-01-31 15:43 ` John Dalbec
2003-01-31 16:06 ` Chris Mason
2003-01-31 21:28 ` John Dalbec
2003-02-03 16:41 ` Chris Mason [this message]
2003-02-04 18:01 ` John Dalbec
2003-02-05 14:24 ` John Dalbec
2003-02-05 16:00 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1044290509.15685.391.camel@tiny.suse.com \
--to=mason@suse.com \
--cc=jpdalbec@ysu.edu \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.