diff for duplicates of <10444.1320436921@death> diff --git a/a/1.txt b/N1/1.txt index f7d9a51..ecb1175 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ Dan Carpenter <dan.carpenter@oracle.com> wrote: >slave->duplex is a u8 type so the in bond_info_show_slave() when we ->check "if (slave->duplex = -1)", it's always false. +>check "if (slave->duplex == -1)", it's always false. > >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > @@ -27,9 +27,9 @@ Dan Carpenter <dan.carpenter@oracle.com> wrote: >@@ -158,12 +158,12 @@ static void bond_info_show_slave(struct seq_file *seq, > seq_printf(seq, "\nSlave Interface: %s\n", slave->dev->name); > seq_printf(seq, "MII Status: %s\n", -> (slave->link = BOND_LINK_UP) ? "up" : "down"); ->- if (slave->speed = -1) ->+ if (slave->speed = SPEED_UNKNOWN) +> (slave->link == BOND_LINK_UP) ? "up" : "down"); +>- if (slave->speed == -1) +>+ if (slave->speed == SPEED_UNKNOWN) > seq_printf(seq, "Speed: %s\n", "Unknown"); > else > seq_printf(seq, "Speed: %d Mbps\n", slave->speed); @@ -51,8 +51,8 @@ Duplex: full DUPLEX_UNKNOWN are needed, but I'm not sure how this #define actually would change any behavior in the bonding case. ->- if (slave->duplex = -1) ->+ if (slave->duplex = DUPLEX_UNKNOWN) +>- if (slave->duplex == -1) +>+ if (slave->duplex == DUPLEX_UNKNOWN) > seq_printf(seq, "Duplex: %s\n", "Unknown"); > else > seq_printf(seq, "Duplex: %s\n", slave->duplex ? "full" : "half"); diff --git a/a/content_digest b/N1/content_digest index a665c42..7559ae8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020111104182138.GB5796@elgon.mountain\0" "From\0Jay Vosburgh <fubar@us.ibm.com>\0" "Subject\0Re: [patch] bonding: comparing a u8 with -1 is always false\0" - "Date\0Fri, 04 Nov 2011 20:02:01 +0000\0" + "Date\0Fri, 04 Nov 2011 13:02:01 -0700\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Weiping Pan <wpan@redhat.com>" Andy Gospodarek <andy@greyhouse.net> @@ -14,7 +14,7 @@ "\n" "Dan Carpenter <dan.carpenter@oracle.com> wrote:\n" ">slave->duplex is a u8 type so the in bond_info_show_slave() when we\n" - ">check \"if (slave->duplex = -1)\", it's always false.\n" + ">check \"if (slave->duplex == -1)\", it's always false.\n" ">\n" ">Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" ">\n" @@ -40,9 +40,9 @@ ">@@ -158,12 +158,12 @@ static void bond_info_show_slave(struct seq_file *seq,\n" "> \tseq_printf(seq, \"\\nSlave Interface: %s\\n\", slave->dev->name);\n" "> \tseq_printf(seq, \"MII Status: %s\\n\",\n" - "> \t\t (slave->link = BOND_LINK_UP) ? \"up\" : \"down\");\n" - ">-\tif (slave->speed = -1)\n" - ">+\tif (slave->speed = SPEED_UNKNOWN)\n" + "> \t\t (slave->link == BOND_LINK_UP) ? \"up\" : \"down\");\n" + ">-\tif (slave->speed == -1)\n" + ">+\tif (slave->speed == SPEED_UNKNOWN)\n" "> \t\tseq_printf(seq, \"Speed: %s\\n\", \"Unknown\");\n" "> \telse\n" "> \t\tseq_printf(seq, \"Speed: %d Mbps\\n\", slave->speed);\n" @@ -64,8 +64,8 @@ "DUPLEX_UNKNOWN are needed, but I'm not sure how this #define actually\n" "would change any behavior in the bonding case.\n" "\n" - ">-\tif (slave->duplex = -1)\n" - ">+\tif (slave->duplex = DUPLEX_UNKNOWN)\n" + ">-\tif (slave->duplex == -1)\n" + ">+\tif (slave->duplex == DUPLEX_UNKNOWN)\n" "> \t\tseq_printf(seq, \"Duplex: %s\\n\", \"Unknown\");\n" "> \telse\n" "> \t\tseq_printf(seq, \"Duplex: %s\\n\", slave->duplex ? \"full\" : \"half\");\n" @@ -99,4 +99,4 @@ "---\n" "\t-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com" -f606b8038b64736d3e2321ef7f77473c9405ae3001575c9ff857129abd94e42f +7cabae8ee2009856cf515e9031698d0d4a1447a79d6a11346b871ee3d644b708
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.