Re: Broken SCSI code in the BK tree (was: 2.5.59-mm8)

[James Bottomley <James.Bottomley@steeleye.com>]

On Thu, 2003-02-06 at 16:30, Martin J. Bligh wrote:
> > OK, I threw a little bit of debug in there:
> > I'd show you the code, except it just ate my root filesystem.
> > Likelihood of me doing further research is thus small.
> 
> 
> Hmmmm .... did a disassemble of this on a similar machine (see end of email)
> data seems to contradict what I was looking at previously ....
> not sure what happened, but this set makes much more sense,
> as it leads to 13c in the offset ;-)
> 
> 0xc01c1ac6 <isp1020_intr_handler+486>:  mov    %eax,0x13c(%ebp)
> which is drivers/scsi/qlogicisp.c:1051
> 
> Cmnd->result = isp1020_return_status(sts);
> 
> seemingly Cmnd is null ... this is in 
[...]

That looks more like it.

My guess is that the command slot was emptied previously, but I don't
understand enough about the mailbox specifics of the isp1020 to be sure.

Can you try adding

if(!Cmnd) {
	printk(KERN_ERR "isp1020 Cmnd is NULL for slot %d, out_ptr %d\n",
cmd_slot, out_ptr);
	continue;
}

Just below the Cmnd = hostdata->cmd_slots[cmd_slot];

> say for sure (if this wasn't related to some SCSI subsystem change, 
> can I just revert out this section?)

No, I'm afraid not.  That was just the elimination of those fields from
Scsi_Cmnd so now it has to be indirect through cmnd->device.  It won't
compile without this.

James