From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: rudmer@legolas.dynup.net,
"Randy.Dunlap" <randy.dunlap@verizon.net>,
Mike Anderson <andmike@us.ibm.com>,
linux-kernel@vger.kernel.org, fischer@norbit.de,
Tommy.Thorn@irisa.fr
Subject: Re: [PATCH] fix scsi/aha15*.c for 2.5.60
Date: 13 Feb 2003 09:10:24 -0500 [thread overview]
Message-ID: <1045145427.2053.48.camel@mulgrave> (raw)
In-Reply-To: <20030212233121.A20476@infradead.org>
On Wed, 2003-02-12 at 18:31, Christoph Hellwig wrote:
> On Wed, Feb 12, 2003 at 05:44:24PM -0500, James Bottomley wrote:
> > > this gives these modules in /lib/modules/2.5.60/kernel/drivers/scsi/:
> > > aha152x.ko scsi_mod.ko sg.ko
> > >
> > > what am i missing??
> >
> > Nothing really, the symbols need to be exported from the SCSI core.
> > I'll add them to the export list.
>
> it should _not_ be exported. drivers are supposed to use the
> request-based interface instead.
Yes, if they issue commands via the mid-layer. This one is queueing a
message (encapsulated as a pseudo command) on it's internal queue (which
is a cmd queue) to issue a bus device reset. In this instance, it
cannot use the request based interface because the device will be
in_recovery when this happens, so it would never be issued.
Personally, it would be nice to have a messaging interface to get around
these problems, but I don't think that one's coming any time soon...
James
prev parent reply other threads:[~2003-02-13 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-12 5:31 [PATCH] fix scsi/aha15*.c for 2.5.60 Randy.Dunlap
2003-02-12 22:41 ` Rudmer van Dijk
2003-02-12 22:44 ` James Bottomley
2003-02-12 22:51 ` Randy.Dunlap
2003-02-12 23:31 ` Christoph Hellwig
2003-02-13 14:10 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045145427.2053.48.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=Tommy.Thorn@irisa.fr \
--cc=andmike@us.ibm.com \
--cc=fischer@norbit.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@verizon.net \
--cc=rudmer@legolas.dynup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.