no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

[Ookhoi]

Hi Reiserfs team,

Today I put a new kernel on a server which has reiserfs and needs quota.
I searched for the quota patches (found them in the mail archive) and
saw that they are very old:

ftp://ftp.namesys.com/pub/reiserfs-for-2.4/testing/quota-2.4.20

3 december 2002. They don't apply to a current kernel. 

I decided to use 2.4.20 with -pre4 and -ac4 patch. 

01-quota-v2-2.4.20.diff has this:
 Quota support
 CONFIG_QUOTA
   If you say Y here, you will be able to set per user limits for disk
-  usage (also called disk quotas). Currently, it works only for the
-  ext2 file system. You need additional software in order to use quota
-  support; for details, read the Quota mini-HOWTO, available from
+  usage (also called disk quotas). Currently, it works for the
+  ext2, ext3, and reiserfs file system. You need additional software
+  in order to use quota support (you can download sources from
+  <http://www.sf.net/projects/linuxquota/>). For further details, read
+  the Quota mini-HOWTO, available from
   <http://www.tldp.org/docs.html#howto>. Probably the quota
   support is only useful for multi user systems. If unsure, say N.


-ac 4 has this:
 Quota support
 CONFIG_QUOTA
   If you say Y here, you will be able to set per user limits for disk
-  usage (also called disk quotas). Currently, it works only for the
-  ext2 file system. You need additional software in order to use quota
-  support; for details, read the Quota mini-HOWTO, available from
+  usage (also called disk quotas). Currently, it works for the
+  ext2, ext3, and reiserfs file system. You need additional software
+  in order to use quota support (you can download sources from
+  <http://www.sf.net/projects/linuxquota/>). For further details, read
+  the Quota mini-HOWTO, available from
   <http://www.tldp.org/docs.html#howto>. Probably the quota
   support is only useful for multi user systems. If unsure, say N.

Because none of the outdated patches apply to -pre4-ac4, and because of
the above in -ac4, I thought that a 2.4.21-pre4-ac4 kernel would have
quota.

This, unfortunately, seems not the case.

I have this line in fstab:
/dev/md1  /        reiserfs noatime,usrquota,grpquota      0  0

and get this error message:
reiserfs_getopt: unknown option "usrquota"

My quota tools are fresh, 3.08.

Did I do something wrong? The setup worked with patched 2.4.19-rc1, but
that one became old and we needed a few more modules. So for now I
assume I'm bitten by no-quota-in-current-2.4-yet.

If I'm right on that; Is there a reason quota is not in 2.4 yet? It has
been stable (for me), and it exists for quite some time now. Did only
half of the patches make it to Alan? The CONFIG_QUOTA is misleading.

Btw, the faq on namesys.com says:
 Is quota-support built-in in the vanilla 2.4 kernels for ReiserFS?

No, quota support for linux kernels from 2.4 branch are bundled
separately and can be obtained from this location. The reason these
patches are not included into 2.4 kernel branch is because they
implement new quota format and need new quota code too, which is too big
of a change for 2.4 series of kernels. Various Linux distributions
vendors (ie SuSE) do ship reiserfs-quota enabled kernels, though.

The "from this location" link points to
ftp://ftp.suse.com/pub/people/mason/patches/reiserfs/quota-2.4 which
contains patches one year old.


May I ask, what is the future of quota in reiserfs for the 2.4 kernel?
Should I wait for new patches? Try to apply them by hand, or did too
much change? Will quota be integrated in the 2.4 kernel soonish?

Thanks for your time!

Re: no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

[Chris Mason]

On Mon, 2003-02-17 at 12:39, Ookhoi wrote:
> Hi Reiserfs team,
> 
> Today I put a new kernel on a server which has reiserfs and needs quota.
> I searched for the quota patches (found them in the mail archive) and
> saw that they are very old:
> 
> ftp://ftp.namesys.com/pub/reiserfs-for-2.4/testing/quota-2.4.20
> 
> 3 december 2002. They don't apply to a current kernel. 
> 

Well, 2.4.20 is the current kernel ;-)  Which kernel do you want them
against?  I've got patches against 2.4.21-preX in testing here, but not
against -ac.  They should merge against -ac now more easily, but I
haven't had time to really test it.

Do you want to try the merge on -ac or would you rather try against
2.4.21-preX

-chris

Re: no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

[Ookhoi]

Chris Mason wrote (ao):
> On Mon, 2003-02-17 at 12:39, Ookhoi wrote:
> > Today I put a new kernel on a server which has reiserfs and needs
> > quota.  I searched for the quota patches (found them in the mail
> > archive) and saw that they are very old:
> > 
> > ftp://ftp.namesys.com/pub/reiserfs-for-2.4/testing/quota-2.4.20
> > 
> > 3 december 2002. They don't apply to a current kernel. 
> 
> Well, 2.4.20 is the current kernel ;-)  Which kernel do you want them
> against?  I've got patches against 2.4.21-preX in testing here, but not
> against -ac.  They should merge against -ac now more easily, but I
> haven't had time to really test it.
> 
> Do you want to try the merge on -ac or would you rather try against
> 2.4.21-preX

Thanks a lot for your quick answer!

Yes, you are of course right that 2.4.20 is the current kernel. My
mistake.

I would love to use -ac, so patches against that would be great. But you
would make me very happy with patches against -pre too.

Is there any chance that you consider your against-ac patches ready for
inclusion in Alan's kernel patches?

Re: no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

[Jan Kara]

  Hello,

> On Mon, 2003-02-17 at 12:39, Ookhoi wrote:
> > Hi Reiserfs team,
> > 
> > Today I put a new kernel on a server which has reiserfs and needs quota.
> > I searched for the quota patches (found them in the mail archive) and
> > saw that they are very old:
> > 
> > ftp://ftp.namesys.com/pub/reiserfs-for-2.4/testing/quota-2.4.20
> > 
> > 3 december 2002. They don't apply to a current kernel. 
> > 
> 
> Well, 2.4.20 is the current kernel ;-)  Which kernel do you want them
> against?  I've got patches against 2.4.21-preX in testing here, but not
> against -ac.  They should merge against -ac now more easily, but I
> haven't had time to really test it.
> 
> Do you want to try the merge on -ac or would you rather try against
> 2.4.21-preX
  Alan has needed changes to generic quota code already in his patchset
so probably just leaving out these changes should make everything work
(but I haven't tested it recently).

								Honza

Re: no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

[Ookhoi]

Jan Kara wrote (ao):
> > On Mon, 2003-02-17 at 12:39, Ookhoi wrote:
> > > Today I put a new kernel on a server which has reiserfs and needs
> > > quota. I searched for the quota patches (found them in the mail
> > > archive) and saw that they are very old:
> > > 
> > > ftp://ftp.namesys.com/pub/reiserfs-for-2.4/testing/quota-2.4.20
> > > 
> > > 3 december 2002. They don't apply to a current kernel. 
> > 
> > Well, 2.4.20 is the current kernel ;-)  Which kernel do you want them
> > against? I've got patches against 2.4.21-preX in testing here, but not
> > against -ac. They should merge against -ac now more easily, but I
> > haven't had time to really test it.
> > 
> > Do you want to try the merge on -ac or would you rather try against
> > 2.4.21-preX
>
> Alan has needed changes to generic quota code already in his patchset
> so probably just leaving out these changes should make everything work
> (but I haven't tested it recently).

You mean, I should use only a few of these?

01-quota-v2-2.4.20.diff
02-nesting-2.4.20.diff
03-reiserfs-quota-23-2.4.20.diff
04-kinoded-8-2.4.20.diff

I'm afraid they don't apply cleanly, though I might just need to try a
bit harder.

OTOH, there must be a reason that Chris _works_ on it ;-)  (eg,
non-trivial)

Anyway, I have the following wishes (yeah, it is not even Christmas!):

o  quota in -ac patches for reiser (like the Configure help already
                                    says ;-)
o  or for -ac patches.
o  updating of the Namesys FAQ on quota patches.
o  peace on earth.

If the people involved can take care of this, I would love to buy them
all a beer or two if they ever come to Amsterdam and if not with too
many at a time. But remember, these are wishes only.

Take care and thanks!!

Re: no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

[Chris Mason]

On Wed, 2003-02-19 at 17:40, Ookhoi wrote:

> > Alan has needed changes to generic quota code already in his patchset
> > so probably just leaving out these changes should make everything work
> > (but I haven't tested it recently).
> 
> You mean, I should use only a few of these?
> 
> 01-quota-v2-2.4.20.diff

Not this, -ac already has it

> 02-nesting-2.4.20.diff
> 03-reiserfs-quota-23-2.4.20.diff

Or these two, I've got an updated reiserfs-quota patch on top of the
data logging code in testing here, it should apply more cleanly on -ac. 
The big delay right now is I'm trying to fix another latency bug in
data=ordered support, and test the fix for the sd_block count on
symlinks.

> 04-kinoded-8-2.4.20.diff
> 
> I'm afraid they don't apply cleanly, though I might just need to try a
> bit harder.
> 
> OTOH, there must be a reason that Chris _works_ on it ;-)  (eg,
> non-trivial)
> 
> Anyway, I have the following wishes (yeah, it is not even Christmas!):
> 
> o  quota in -ac patches for reiser (like the Configure help already
>                                     says ;-)

I doubt I'll send it to Alan, keeping up with vanilla and the suse
kernels is hard enough ;-)  If someone wants to actively work with me on
maintaining them in the ac tree, drop me a private message and we should
be able to work something out.

-chris

Re: no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

[Oleg Drokin]

Hello!

On Wed, Feb 19, 2003 at 08:10:11PM -0500, Chris Mason wrote:
> > > Alan has needed changes to generic quota code already in his patchset
> > > so probably just leaving out these changes should make everything work
> > > (but I haven't tested it recently).
> > You mean, I should use only a few of these?
> > 01-quota-v2-2.4.20.diff
> Not this, -ac already has it

> > o  quota in -ac patches for reiser (like the Configure help already
> >                                     says ;-)
> I doubt I'll send it to Alan, keeping up with vanilla and the suse
> kernels is hard enough ;-)  If someone wants to actively work with me on
> maintaining them in the ac tree, drop me a private message and we should
> be able to work something out.

I think if Hans would agree to that idea, I can do this.
After all - we are interested to have working reiserfs quota support
in RedHat's default kernels. And those are largely based on -ac patches.
Hans?

Bye,
    Oleg

Re: no reiserfs quota in 2.4 yet? 2.4.21-pre4-ac4 says different

[Dieter Nützel]

Am Donnerstag, 20. Februar 2003 02:10 schrieb Chris Mason:
> On Wed, 2003-02-19 at 17:40, Ookhoi wrote:
> > > Alan has needed changes to generic quota code already in his patchset
> > > so probably just leaving out these changes should make everything work
> > > (but I haven't tested it recently).
> >
> > You mean, I should use only a few of these?
> >
> > 01-quota-v2-2.4.20.diff
>
> Not this, -ac already has it
>
> > 02-nesting-2.4.20.diff
> > 03-reiserfs-quota-23-2.4.20.diff
>
> Or these two, I've got an updated reiserfs-quota patch on top of the
> data logging code in testing here, it should apply more cleanly on -ac.
> The big delay right now is I'm trying to fix another latency bug in
> data=ordered support, and test the fix for the sd_block count on
> symlinks.

Chris do you have something handy (data=ordered latency)?
I'll give it a try with my lantency "test" under 2.4.21pre4aa3.

Thanks,
	Dieter

-- 
Dieter Nützel
Graduate Student, Computer Science

University of Hamburg
Department of Computer Science
@home: Dieter.Nuetzel at hamburg.de (replace at with @)