From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 3/4] drm: Add NV24 and NV42 pixel formats
Date: Wed, 30 May 2012 15:20:09 +0200
Message-ID: <10458627.VBMA7d1R5q@avalon>
References: <1338381179-13290-1-git-send-email-laurent.pinchart@ideasonboard.com>
	<1338381179-13290-4-git-send-email-laurent.pinchart@ideasonboard.com>
	<20120530130925.GR13065@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
	[95.142.166.194])
	by gabe.freedesktop.org (Postfix) with ESMTP id 622029E801
	for <dri-devel@lists.freedesktop.org>;
	Wed, 30 May 2012 06:19:47 -0700 (PDT)
In-Reply-To: <20120530130925.GR13065@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Ville,

Thank you for the review.

On Wednesday 30 May 2012 16:09:25 Ville Syrj=E4l=E4 wrote:
> On Wed, May 30, 2012 at 02:32:58PM +0200, Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > =

> >  include/drm/drm_fourcc.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > =

> > diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
> > index bdf0152..fac7235 100644
> > --- a/include/drm/drm_fourcc.h
> > +++ b/include/drm/drm_fourcc.h
> > @@ -106,6 +106,8 @@
> > =

> >  #define DRM_FORMAT_NV21		fourcc_code('N', 'V', '2', '1') /* 2x2
> >  subsampled Cb:Cr plane */ #define DRM_FORMAT_NV16		fourcc_code('N', =

'V',
> >  '1', '6') /* 2x1 subsampled Cr:Cb plane */ #define
> >  DRM_FORMAT_NV61		fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled =

Cb:Cr
> >  plane */> =

> > +#define DRM_FORMAT_NV24		fourcc_code('N', 'V', '2', '4') /*
> > non-subsampled Cr:Cb plane */ +#define DRM_FORMAT_NV42		=

fourcc_code('N',
> > 'V', '4', '2') /* non-subsampled Cb:Cr plane */
> If you want these to reach the driver you need to add them to
> format_check().

Oops, my bad, indeed.

> Also you should update drm_format_num_planes() and drm_format_plane_cpp()
> appropriately.

Will do.

I'm a bit puzzled by drm_format_plane_cpp(). I would have expected the retu=
rn =

value to be 1 for NV12/21 and NV16/61 formats (2 U/V components, but 1/2 =

horizontal subsampling). Is that a bug, or am I missing something ?

-- =

Regards,

Laurent Pinchart