From: Albert Cahalan <albert@users.sf.net>
To: linux-kernel@vger.kernel.org
Cc: davem@redhat.com, rddunlap@osdl.org
Subject: Re: [PATCH] add new DMA_ADDR_T_SIZE define
Date: 23 Feb 2003 02:02:01 -0500 [thread overview]
Message-ID: <1045983722.32116.8.camel@cube> (raw)
David S. Miller writes:
> On Wed, 2003-02-19 at 09:28, Ion Badulescu wrote:
>> then you're probably debugging, not performance-tuning,
>> so the cast to u64 is acceptable.
>
> Not true, you must cast to 'long long' as there is no
> appropriate printf format string for u64 that works
> warning-free on all systems.
Casts are ugly and they hide bugs. There is a fix
for this problem: make u64 be "unsigned long long"
for every arch. That works for both 32-bit and 64-bit
systems. Likewise, choose "unsigned" for u32 even
if an "unsigned long" would work for a given arch.
next reply other threads:[~2003-02-23 6:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-23 7:02 Albert Cahalan [this message]
2003-02-23 7:00 ` [PATCH] add new DMA_ADDR_T_SIZE define David S. Miller
2003-02-23 7:20 ` Albert Cahalan
-- strict thread matches above, loose matches on Subject: below --
2003-02-19 18:11 James Bottomley
2003-02-19 18:20 ` Ion Badulescu
2003-02-19 22:07 ` David S. Miller
2003-02-19 22:41 ` Ion Badulescu
2003-02-19 22:29 ` David S. Miller
2003-02-19 22:53 ` Ion Badulescu
2003-02-19 22:38 ` David S. Miller
2003-02-19 16:26 Ion Badulescu
2003-02-19 17:20 ` Randy.Dunlap
2003-02-19 17:28 ` Ion Badulescu
2003-02-19 22:06 ` David S. Miller
2003-02-19 22:04 ` Ion Badulescu
2003-02-19 22:06 ` David S. Miller
2003-02-19 21:48 ` Jeff Garzik
2003-02-22 10:06 ` Ingo Oeser
2003-02-19 22:01 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045983722.32116.8.camel@cube \
--to=albert@users.sf.net \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.