All of lore.kernel.org
 help / color / mirror / Atom feed
From: belouargamohamed@gmail.com
To: openembedded-core@lists.openembedded.org
Subject: Re: [kirkstone][PATCH 1/5] recipetool: create: npm: Remove duplicate function to not have future conflicts
Date: Mon, 29 May 2023 13:16:53 -0700	[thread overview]
Message-ID: <1046.1685391413156535299@lists.openembedded.org> (raw)
In-Reply-To: <CAOSpxdYft-9vk_Cb3VJY-pUoHJF2nyYBneiH=wXCueVdUqiLwA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Yes, the same issues are present in master branch.

But this series of patches won't work on master, it needs some adaptation.

Because in kirkstone we have Nodejs 16.19.1 and in master we have Nodejs 18.16, and they generate shrinkwrap files that are slightly different.

For Mickledore, I didn't test yet but I think that it will work like in the master branch.

Note: these changes work only if my patch for bitbake is accepted: https://lists.openembedded.org/g/bitbake-devel/topic/kirkstone_patch_fetch2/99163598?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,99163598,previd%3D1685367798112436212,nextid%3D1683629533018906083&previd=1685367798112436212&nextid=1683629533018906083

Best regards,
BELOUARGA Mohamed

[-- Attachment #2: Type: text/html, Size: 1265 bytes --]

  reply	other threads:[~2023-05-29 20:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-27  6:25 [kirkstone][PATCH 1/5] recipetool: create: npm: Remove duplicate function to not have future conflicts belouargamohamed
2023-05-27  6:25 ` [kirkstone][PATCH 2/5] classes: npm: Handle peer dependencies for npm packages belouargamohamed
2023-05-27  6:25 ` [kirkstone][PATCH 3/5] recipetool: create: npm: Add support for the new format of the shrinkwrap file belouargamohamed
2023-05-27  6:25 ` [kirkstone][PATCH 4/5] recipetool: create: npm: Add support to handle peer dependencies belouargamohamed
2023-05-27  6:25 ` [kirkstone][PATCH 5/5] classes: npm: Add support for the new format of the shrinkwrap file belouargamohamed
2023-05-29 15:13 ` [OE-core] [kirkstone][PATCH 1/5] recipetool: create: npm: Remove duplicate function to not have future conflicts Steve Sakoman
2023-05-29 20:16   ` belouargamohamed [this message]
     [not found]     ` <CAOSpxda3AWOQfskRpCWB0zQMDHs+SMKz0RGqE5z2Nd80DRKp7g@mail.gmail.com>
2023-05-29 22:59       ` Fwd: " Steve Sakoman
2023-05-31 20:27         ` belouargamohamed
  -- strict thread matches above, loose matches on Subject: below --
2023-05-27  6:17 belouargamohamed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1046.1685391413156535299@lists.openembedded.org \
    --to=belouargamohamed@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.