All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Lynch <rusty@linux.co.intel.com>
To: "David S. Miller" <davem@redhat.com>
Cc: miyazawa@linux-ipv6.org, linux-kernel@vger.kernel.org
Subject: Re: Latest bk build error in xfrm.h
Date: 06 Mar 2003 17:24:04 -0800	[thread overview]
Message-ID: <1047000245.4169.45.camel@vmhack> (raw)
In-Reply-To: <20030306.160300.126216253.davem@redhat.com>

On Thu, 2003-03-06 at 16:03, David S. Miller wrote:
>    From: Rusty Lynch <rusty@linux.co.intel.com>
>    Date: 06 Mar 2003 13:38:44 -0800
> 
>    The problem is now the core networking has a dependency on the crypto
>    hmac code (CONFIG_CRYOTPO_HMAC) since the ipv4 ipsec code was added to
>    include/net/xfrm.h (which is included from all kinds of places.)
>    
>    The pretty much exhaust my networking/ipsec knowledge so no patch.
>    
> I just pushed the following patch to Linus, should fix the build for
> everyone.  It's also available at:
> 
> 	bk://kernel.bkbits.net/davem/netfix-2.5
> 
> Thanks.
> 
> ChangeSet@1.1075.2.1, 2003-03-06 16:17:07-08:00, davem@nuts.ninka.net
>   [IPSEC]: Fix build when ipsec is disabled.
> 

There is still a build dependency between the INET_AH/INET_ESP and
CRYPTO_HMAC that the Kconfig does not cover.  The following trivial
patch fixes it:

--- net/ipv4/Kconfig.orig	2003-03-06 17:36:13.000000000 -0800
+++ net/ipv4/Kconfig	2003-03-06 17:37:38.000000000 -0800
@@ -350,6 +350,7 @@
 
 config INET_AH
 	tristate "IP: AH transformation"
+	depends on CRYPTO_HMAC
 	---help---
 	  Support for IPsec AH.
 
@@ -357,6 +358,7 @@
 
 config INET_ESP
 	tristate "IP: ESP transformation"
+	depends on CRYPTO_HMAC
 	---help---
 	  Support for IPsec ESP.
 
 


  reply	other threads:[~2003-03-07  1:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-06 19:47 Latest bk build error in xfrm.h Rusty Lynch
2003-03-06 21:38 ` Rusty Lynch
2003-03-06 23:27   ` David S. Miller
2003-03-07  0:03   ` David S. Miller
2003-03-07  1:24     ` Rusty Lynch [this message]
2003-03-07  6:18       ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1047000245.4169.45.camel@vmhack \
    --to=rusty@linux.co.intel.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miyazawa@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.