From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v4 5/6] selftests: mptcp: join: print title after init_partial
Date: Fri, 24 May 2024 13:09:16 +0200 [thread overview]
Message-ID: <10479e4f-16d3-4de4-95c5-41c17da16198@kernel.org> (raw)
In-Reply-To: <4716cd1f4f594b2cc68e9e6692898eb725de8ce5.1716533107.git.tanggeliang@kylinos.cn>
On 24/05/2024 08:48, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> init_partial may fail sometimes, in that case, titles shouldn't be
> printed out. So the patch moves mptcp_lib_print_title from the front
> of init_partial to the back of it.
I'm not sure to understand why the title should not be printed: it would
help to understand which test had an issue: the next one or the previous
one, no?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-05-24 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 6:48 [PATCH mptcp-next v4 0/6] use helpers in lib.sh and net_helpers.sh Geliang Tang
2024-05-24 6:48 ` [PATCH mptcp-next v4 1/6] selftests: net: rename ns in setup/cleanup_ns Geliang Tang
2024-05-24 11:09 ` Matthieu Baerts
2024-05-24 6:48 ` [PATCH mptcp-next v4 2/6] selftests: mptcp: rename ns to _ns in get_counter Geliang Tang
2024-05-24 11:09 ` Matthieu Baerts
2024-05-24 6:48 ` [PATCH mptcp-next v4 3/6] selftests: mptcp: use setup/cleanup_ns helpers Geliang Tang
2024-05-24 6:48 ` [PATCH mptcp-next v4 4/6] selftests: mptcp: diag: trap cleanup after ns_init Geliang Tang
2024-05-24 6:48 ` [PATCH mptcp-next v4 5/6] selftests: mptcp: join: print title after init_partial Geliang Tang
2024-05-24 11:09 ` Matthieu Baerts [this message]
2024-05-24 6:48 ` [PATCH mptcp-next v4 6/6] selftests: mptcp: use wait_local_port_listen helper Geliang Tang
2024-05-24 7:41 ` [PATCH mptcp-next v4 0/6] use helpers in lib.sh and net_helpers.sh MPTCP CI
2024-05-24 9:35 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10479e4f-16d3-4de4-95c5-41c17da16198@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.