From: Christian Neumair <chris@gnome-de.org>
To: linux-kernel@vger.kernel.org
Subject: [RESENT] [PATCH-2.5] Tiny compile include fix
Date: 24 Mar 2003 15:58:37 +0100 [thread overview]
Message-ID: <1048517916.9008.14.camel@localhost> (raw)
Hi there!
I don't know whether there where formal reasons that prevented Linus
from commiting the included patch.
If so, please clarify why you rejected it.
I changed "#include <asm/pgalloc.h>"'s position because i'd like to use
alphabetical include order where possible.
The patch sent with this email fixes the following compile problem:
-- snip --
In file included from arch/i386/kernel/acpi/boot.c:34:
include/asm-i386/mach-numaq/mach_apic.h: In function
`setup_portio_remap':
include/asm-i386/mach-numaq/mach_apic.h:96: `xquad_portio' undeclared
(first use in this function)
include/asm-i386/mach-numaq/mach_apic.h:96: (Each undeclared identifier
is reported only once
include/asm-i386/mach-numaq/mach_apic.h:96: for each function it appears
in.)
include/asm-i386/mach-numaq/mach_apic.h:96: warning: implicit
declaration of function `ioremap'
include/asm-i386/mach-numaq/mach_apic.h:96: `XQUAD_PORTIO_BASE'
undeclared (first use in this function)
include/asm-i386/mach-numaq/mach_apic.h:96: `XQUAD_PORTIO_QUAD'
undeclared (first use in this function)
include/asm-i386/mach-numaq/mach_mpparse.h: At top level:
include/asm-i386/mach-numaq/mach_mpparse.h:5: warning:
`smp_read_mpc_oem' declared `static' but never defined
make[2]: *** [arch/i386/kernel/acpi/boot.o] Fehler 1
make[1]: *** [arch/i386/kernel/acpi] Fehler 2
make: *** [arch/i386/kernel] Fehler 2
-- snap --
This is my first patch sent to this ML so I hope to have respected all
formal guidelines.
regs,
Chris
Index: arch/i386/kernel/acpi/boot.c
===================================================================
RCS file: /home/cvs/linux-2.5/arch/i386/kernel/acpi/boot.c,v
retrieving revision 1.4
diff -u -r1.4 boot.c
--- arch/i386/kernel/acpi/boot.c 27 Feb 2003 16:44:23 -0000 1.4
+++ arch/i386/kernel/acpi/boot.c 23 Mar 2003 07:59:32 -0000
@@ -26,9 +26,10 @@
#include <linux/init.h>
#include <linux/config.h>
#include <linux/acpi.h>
-#include <asm/pgalloc.h>
#include <asm/apic.h>
+#include <asm/io.h>
#include <asm/mpspec.h>
+#include <asm/pgalloc.h>
#if defined (CONFIG_X86_LOCAL_APIC)
#include <mach_apic.h>
reply other threads:[~2003-03-24 14:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1048517916.9008.14.camel@localhost \
--to=chris@gnome-de.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.