From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCE7BC2BD09 for ; Mon, 24 Jun 2024 09:01:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B6CF10E3B9; Mon, 24 Jun 2024 09:01:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.b="nbZ12EAs"; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="eWvknj2a"; dkim-atps=neutral Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7E2810E3B9 for ; Mon, 24 Jun 2024 09:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1719219667; x=1750755667; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5x2MLDbjr/RPEmqtLCf9iT+BPMyk5xAgQh7bhsnND/U=; b=nbZ12EAsHfm+BJPJTQdfDZBxtbM531ayLD2btAJOiqsUtjZcQ2R9xoBt MoJT6mnx+HoTiQXRqFJ11/KLNk9JG017V2rGpAhUuQ4QF+VfpOVAwz6J8 EWFIjBBPfTv05FHG3aszovLid+8scnvchHfQniLtaQhgpm09vfLCY2gMy R1kchEIz72JEdSBwYxfky9qTWrk0RZIP5szSqdVbEqvbNHoMpPIyl8htk YkW+oQnV/Y/wiTHrrWMIhXcuAHW2Mbc0+Hxw2xeNDRCgtQgNCDDCI1Rmq OT9oBptmhyP+UDo/BJqJIkFozot0U7RNnz+V74g8dYqF0OMNPJwAqJg3t g==; X-CSE-ConnectionGUID: VlfquXtyRHCnhupHD1Yz5Q== X-CSE-MsgGUID: Jy/k0qiJTEy3RNUxB4tdnQ== X-IronPort-AV: E=Sophos;i="6.08,261,1712613600"; d="scan'208";a="37546919" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 24 Jun 2024 11:01:06 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7C77316699B; Mon, 24 Jun 2024 11:00:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1719219662; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=5x2MLDbjr/RPEmqtLCf9iT+BPMyk5xAgQh7bhsnND/U=; b=eWvknj2akVfXG3u7NcQRx/6FTxTQtks2bp+2ulFTJIDYeF4Nxy1DvE9XTkSaKZa7rk0n/d e/ZseEl6GcHz3HQ6QNyFNeEmpPjQPUcDA5cs0uVvL6NRDxRfchp+dovTda0IjY3A2BCwTi GRRMSE5shuLdByJt4AzY8mhPf1vijGCFBqmyxx3Rvq+3LNA+iM3Xug1cGh1pkx/q32wbNC x/ViXuTPE3x+Xe+PXVGycyHreacXGzX4UBXiOH2aX3BOGtS74p+UzD9zMOO0yMp3UNfOBA YEg6yBevmlxyv4mZJuHHfH+x+csydSncbkB7BVqN7Qd7PeBLOrxqaHOZZLOHEg== From: Alexander Stein To: dri-devel@lists.freedesktop.org Cc: Marek Vasut , Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Lucas Stach , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , kernel@dh-electronics.com, Marek Vasut Subject: Re: [PATCH v3 3/6] drm/bridge: tc358767: Drop line_pixel_subtract Date: Mon, 24 Jun 2024 11:00:50 +0200 Message-ID: <10489349.nUPlyArG6x@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240623143846.12603-3-marex@denx.de> References: <20240623143846.12603-1-marex@denx.de> <20240623143846.12603-3-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Sonntag, 23. Juni 2024, 16:38:35 CEST schrieb Marek Vasut: > This line_pixel_subtract is no longer needed now that the bridge can > request and obtain specific pixel clock on input to the bridge, with > clock frequency that matches the Pixel PLL frequency. >=20 > The line_pixel_subtract is now always 0, so drop it entirely. >=20 > The line_pixel_subtract was not reliable as it never worked when the > Pixel PLL and input clock were off just so that the required amount > of pixels to subtract would not be whole integer. >=20 > Signed-off-by: Marek Vasut =46or me is even necessary to get the DP test mode running, using DSI as in= put. With the removal of div64_round_up() from patch 1 addeded here: Reviewed-by: Alexander Stein > --- > Cc: Andrzej Hajda > Cc: Daniel Vetter > Cc: David Airlie > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Thomas Zimmermann > Cc: dri-devel@lists.freedesktop.org > Cc: kernel@dh-electronics.com > --- > V2: No change > V3: Fix up rebase artifact > --- > drivers/gpu/drm/bridge/tc358767.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) >=20 > diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/t= c358767.c > index 20be21660ba76..c4e2455ad95e4 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -382,9 +382,6 @@ struct tc_data { > =20 > /* HPD pin number (0 or 1) or -ENODEV */ > int hpd_pin; > - > - /* Number of pixels to subtract from a line due to pixel clock delta */ > - u32 line_pixel_subtract; > }; > =20 > static inline struct tc_data *aux_to_tc(struct drm_dp_aux *a) > @@ -661,11 +658,7 @@ static int tc_pxl_pll_calc(struct tc_data *tc, u32 r= efclk, u32 pixelclock, > return -EINVAL; > } > =20 > - tc->line_pixel_subtract =3D tc->mode.htotal - > - div64_round_up(tc->mode.htotal * (u64)best_pixelclock, pixelclock); > - > - dev_dbg(tc->dev, "PLL: got %d, delta %d (subtract %d px)\n", best_pixel= clock, > - best_delta, tc->line_pixel_subtract); > + dev_dbg(tc->dev, "PLL: got %d, delta %d\n", best_pixelclock, best_delta= ); > dev_dbg(tc->dev, "PLL: %d / %d / %d * %d / %d\n", refclk, > ext_div[best_pre], best_div, best_mul, ext_div[best_post]); > =20 > @@ -909,13 +902,6 @@ static int tc_set_common_video_mode(struct tc_data *= tc, > upper_margin, lower_margin, vsync_len); > dev_dbg(tc->dev, "total: %dx%d\n", mode->htotal, mode->vtotal); > =20 > - if (right_margin > tc->line_pixel_subtract) { > - right_margin -=3D tc->line_pixel_subtract; > - } else { > - dev_err(tc->dev, "Bridge pixel clock too slow for mode\n"); > - right_margin =3D 0; > - } > - > /* > * LCD Ctl Frame Size > * datasheet is not clear of vsdelay in case of DPI >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/