All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Koninckx <bob.koninckx@mech.kuleuven.ac.be>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Cc: ecos-discuss@sources.redhat.com
Subject: Re: jffs2 / eCos
Date: 02 Apr 2003 21:32:06 +0200	[thread overview]
Message-ID: <1049311926.3315.12.camel@pc-002> (raw)
In-Reply-To: <1049271603.4175.4.camel@imladris.demon.co.uk>

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

On Wed, 2003-04-02 at 10:20, David Woodhouse wrote:
> On Wed, 2003-04-02 at 08:48, Bob Koninckx wrote:
> > > We should just fix jffs2_read_inode_range() to handle reads which don't
> > > start at the beginning of a node. It's not hard.
> > 
> > I removed the above mentioned check and now it _appears_ to work
> > correctly. Is this all that needs to be done ?
> 
> Can you show me the patch or resulting code? 


Just commented the lines containing the test out. Anyway, if you want a
patch to see it for yourself... :-)


> 
> > Are there similar issues when writing to the filesys ?
> 
> No, writing should be fine -- but you really do want to try to ensure
> that you don't get writes split up into 256-byte chunks, since that'll
> waste space on the file system (till it gets GC'd and merged).


Certainly won't be before the week-end. You don't have by any chance any
(standard) test cases, do you ? Any suggestions to seriously test it
(apart from creating a file that is larger than 256 bytes and checking
with the debugger that no "holes" are left)

Thanks for looking after this so far anyway,

Bob

>  
-- 
----------------------------------------------------------------------
ir. Bob Koninckx
Katholieke Universiteit Leuven
Division Production Engineering,                   tel.  +32 16 322535
Machine Design and Automation                      fax.  +32 16 322987
Celestijnenlaan 300B                  bob.koninckx@mech.kuleuven.ac.be
B-3001 Leuven Belgium               http://www.mech.kuleuven.ac.be/pma
----------------------------------------------------------------------

[-- Attachment #2: jffs.patch --]
[-- Type: text/plain, Size: 1395 bytes --]

? jffs.patch
Index: read.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/fs/jffs2/current/src/read.c,v
retrieving revision 1.3
diff -u -5 -r1.3 read.c
--- read.c	5 Feb 2003 00:00:40 -0000	1.3
+++ read.c	2 Apr 2003 19:18:14 -0000
@@ -175,16 +175,16 @@
 			D1(printk(KERN_DEBUG "Filling non-frag hole from %d-%d\n", offset, offset+holesize));
 			memset(buf, 0, holesize);
 			buf += holesize;
 			offset += holesize;
 			continue;
-		} else if (frag->ofs < offset && (offset & (PAGE_CACHE_SIZE-1)) != 0) {
-			D1(printk(KERN_NOTICE "Eep. Overlap in ino #%u fraglist. frag->ofs = 0x%08x, offset = 0x%08x\n",
-				  f->inocache->ino, frag->ofs, offset));
-			D1(jffs2_print_frag_list(f));
-			memset(buf, 0, end - offset);
-			return -EIO;
+//		} else if (frag->ofs < offset && (offset & (PAGE_CACHE_SIZE-1)) != 0) {
+//			D1(printk(KERN_NOTICE "Eep. Overlap in ino #%u fraglist. frag->ofs = 0x%08x, offset = 0x%08x\n",
+//				  f->inocache->ino, frag->ofs, offset));
+//			D1(jffs2_print_frag_list(f));
+//			memset(buf, 0, end - offset);
+//			return -EIO;
 		} else if (!frag->node) {
 			uint32_t holeend = min(end, frag->ofs + frag->size);
 			D1(printk(KERN_DEBUG "Filling frag hole from %d-%d (frag 0x%x 0x%x)\n", offset, holeend, frag->ofs, frag->ofs + frag->size));
 			memset(buf, 0, holeend - offset);
 			buf += holeend - offset;

      reply	other threads:[~2003-04-02 19:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-30 20:49 jffs2 / eCos Bob Koninckx
2003-03-30 21:22 ` Jörn Engel
2003-03-31  6:26   ` Bob Koninckx
2003-03-31  6:50     ` Jörn Engel
2003-03-31  7:17 ` David Woodhouse
2003-03-31 20:29   ` [ECOS] " Bob Koninckx
2003-03-31 22:47     ` David Woodhouse
2003-04-02  7:48       ` Bob Koninckx
2003-04-02  8:20         ` David Woodhouse
2003-04-02 19:32           ` Bob Koninckx [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1049311926.3315.12.camel@pc-002 \
    --to=bob.koninckx@mech.kuleuven.ac.be \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.