* [PATCH 1/2] Tracepoint API doc update: data argument
@ 2014-03-11 1:04 Mathieu Desnoyers
2014-03-11 1:04 ` [PATCH 2/2] Tracepoint API doc update: tracepoint_probe_register() return value Mathieu Desnoyers
2014-03-11 23:34 ` [PATCH 1/2] Tracepoint API doc update: data argument Steven Rostedt
0 siblings, 2 replies; 6+ messages in thread
From: Mathieu Desnoyers @ 2014-03-11 1:04 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, Mathieu Desnoyers, Ingo Molnar, Frederic Weisbecker,
Andrew Morton
Describe the @data argument (probe private data).
Fixes: 38516ab59fbc "tracing: Let tracepoints have data passed to tracepoint callbacks"
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Ingo Molnar <mingo@kernel.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
---
kernel/tracepoint.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
index 444e416..49cb94e 100644
--- a/kernel/tracepoint.c
+++ b/kernel/tracepoint.c
@@ -376,6 +376,7 @@ tracepoint_add_probe(const char *name, void *probe, void *data)
* tracepoint_probe_register - Connect a probe to a tracepoint
* @name: tracepoint name
* @probe: probe handler
+ * @data: probe private data
*
* Returns 0 if ok, error value on error.
* The probe address must at least be aligned on the architecture pointer size.
@@ -424,6 +425,7 @@ tracepoint_remove_probe(const char *name, void *probe, void *data)
* tracepoint_probe_unregister - Disconnect a probe from a tracepoint
* @name: tracepoint name
* @probe: probe function pointer
+ * @data: probe private data
*
* We do not need to call a synchronize_sched to make sure the probes have
* finished running before doing a module unload, because the module unload
@@ -464,6 +466,7 @@ static void tracepoint_add_old_probes(void *old)
* tracepoint_probe_register_noupdate - register a probe but not connect
* @name: tracepoint name
* @probe: probe handler
+ * @data: probe private data
*
* caller must call tracepoint_probe_update_all()
*/
@@ -488,6 +491,7 @@ EXPORT_SYMBOL_GPL(tracepoint_probe_register_noupdate);
* tracepoint_probe_unregister_noupdate - remove a probe but not disconnect
* @name: tracepoint name
* @probe: probe function pointer
+ * @data: probe private data
*
* caller must call tracepoint_probe_update_all()
*/
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Tracepoint API doc update: tracepoint_probe_register() return value
2014-03-11 1:04 [PATCH 1/2] Tracepoint API doc update: data argument Mathieu Desnoyers
@ 2014-03-11 1:04 ` Mathieu Desnoyers
2014-03-11 23:34 ` [PATCH 1/2] Tracepoint API doc update: data argument Steven Rostedt
1 sibling, 0 replies; 6+ messages in thread
From: Mathieu Desnoyers @ 2014-03-11 1:04 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, Mathieu Desnoyers, Ingo Molnar, Frederic Weisbecker,
Andrew Morton
Describe the return values of tracepoint_probe_register(), including
-ENODEV added by commit:
Author: Steven Rostedt <rostedt@goodmis.org>
tracing: Warn if a tracepoint is not set via debugfs
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Ingo Molnar <mingo@kernel.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
---
kernel/tracepoint.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
index 49cb94e..0839258 100644
--- a/kernel/tracepoint.c
+++ b/kernel/tracepoint.c
@@ -378,7 +378,17 @@ tracepoint_add_probe(const char *name, void *probe, void *data)
* @probe: probe handler
* @data: probe private data
*
- * Returns 0 if ok, error value on error.
+ * Returns:
+ * - 0 if the probe was successfully registered, and tracepoint
+ * callsites are currently loaded for that probe,
+ * - -ENODEV if the probe was successfully registered, but no tracepoint
+ * callsite is currently loaded for that probe,
+ * - other negative error value on error.
+ *
+ * When tracepoint_probe_register() returns either 0 or -ENODEV,
+ * parameters @name, @probe, and @data may be used by the tracepoint
+ * infrastructure until the probe is unregistered.
+ *
* The probe address must at least be aligned on the architecture pointer size.
*/
int tracepoint_probe_register(const char *name, void *probe, void *data)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Tracepoint API doc update: data argument
2014-03-11 1:04 [PATCH 1/2] Tracepoint API doc update: data argument Mathieu Desnoyers
2014-03-11 1:04 ` [PATCH 2/2] Tracepoint API doc update: tracepoint_probe_register() return value Mathieu Desnoyers
@ 2014-03-11 23:34 ` Steven Rostedt
2014-03-12 0:52 ` Mathieu Desnoyers
1 sibling, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2014-03-11 23:34 UTC (permalink / raw)
To: Mathieu Desnoyers
Cc: linux-kernel, Ingo Molnar, Frederic Weisbecker, Andrew Morton
On Mon, 10 Mar 2014 21:04:57 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> Describe the @data argument (probe private data).
>
> Fixes: 38516ab59fbc "tracing: Let tracepoints have data passed to tracepoint callbacks"
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Ingo Molnar <mingo@kernel.org>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
No signed-off-by.
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Tracepoint API doc update: data argument
2014-03-11 23:34 ` [PATCH 1/2] Tracepoint API doc update: data argument Steven Rostedt
@ 2014-03-12 0:52 ` Mathieu Desnoyers
2014-03-12 1:14 ` Steven Rostedt
0 siblings, 1 reply; 6+ messages in thread
From: Mathieu Desnoyers @ 2014-03-12 0:52 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, Ingo Molnar, Frederic Weisbecker, Andrew Morton
----- Original Message -----
> From: "Steven Rostedt" <rostedt@goodmis.org>
> To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>, "Frederic Weisbecker" <fweisbec@gmail.com>,
> "Andrew Morton" <akpm@linux-foundation.org>
> Sent: Tuesday, March 11, 2014 7:34:50 PM
> Subject: Re: [PATCH 1/2] Tracepoint API doc update: data argument
>
> On Mon, 10 Mar 2014 21:04:57 -0400
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>
> > Describe the @data argument (probe private data).
> >
> > Fixes: 38516ab59fbc "tracing: Let tracepoints have data passed to
> > tracepoint callbacks"
> > CC: Steven Rostedt <rostedt@goodmis.org>
> > CC: Ingo Molnar <mingo@kernel.org>
> > CC: Frederic Weisbecker <fweisbec@gmail.com>
> > CC: Andrew Morton <akpm@linux-foundation.org>
>
> No signed-off-by.
Hi Steven,
I'm curious to understand the reason of this "no signed-off-by" on a trivial
patch that fixes the missing DocBook comments for one of your previous
commits that has been upstream for a few years. What am I missing ?
Perhaps you meant this reply for my other documentation update patch (2/2) ?
Thanks,
Mathieu
>
> -- Steve
>
>
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Tracepoint API doc update: data argument
2014-03-12 0:52 ` Mathieu Desnoyers
@ 2014-03-12 1:14 ` Steven Rostedt
2014-03-12 1:30 ` Mathieu Desnoyers
0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2014-03-12 1:14 UTC (permalink / raw)
To: Mathieu Desnoyers
Cc: linux-kernel, Ingo Molnar, Frederic Weisbecker, Andrew Morton
On Wed, 12 Mar 2014 00:52:33 +0000 (UTC)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> ----- Original Message -----
> > From: "Steven Rostedt" <rostedt@goodmis.org>
> > To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> > Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>, "Frederic Weisbecker" <fweisbec@gmail.com>,
> > "Andrew Morton" <akpm@linux-foundation.org>
> > Sent: Tuesday, March 11, 2014 7:34:50 PM
> > Subject: Re: [PATCH 1/2] Tracepoint API doc update: data argument
> >
> > On Mon, 10 Mar 2014 21:04:57 -0400
> > Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> >
> > > Describe the @data argument (probe private data).
> > >
> > > Fixes: 38516ab59fbc "tracing: Let tracepoints have data passed to
> > > tracepoint callbacks"
> > > CC: Steven Rostedt <rostedt@goodmis.org>
> > > CC: Ingo Molnar <mingo@kernel.org>
> > > CC: Frederic Weisbecker <fweisbec@gmail.com>
> > > CC: Andrew Morton <akpm@linux-foundation.org>
> >
> > No signed-off-by.
>
> Hi Steven,
>
> I'm curious to understand the reason of this "no signed-off-by" on a trivial
> patch that fixes the missing DocBook comments for one of your previous
> commits that has been upstream for a few years. What am I missing ?
> Perhaps you meant this reply for my other documentation update patch (2/2) ?
>
I mean, my scripts wont accept a patch that the author never added
their signed-off-by to.
In other words, resubmit, and add your own signed-off-by that happens to
be missing from this patch.
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Tracepoint API doc update: data argument
2014-03-12 1:14 ` Steven Rostedt
@ 2014-03-12 1:30 ` Mathieu Desnoyers
0 siblings, 0 replies; 6+ messages in thread
From: Mathieu Desnoyers @ 2014-03-12 1:30 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, Ingo Molnar, Frederic Weisbecker, Andrew Morton
----- Original Message -----
> From: "Steven Rostedt" <rostedt@goodmis.org>
> To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>, "Frederic Weisbecker" <fweisbec@gmail.com>,
> "Andrew Morton" <akpm@linux-foundation.org>
> Sent: Tuesday, March 11, 2014 9:14:02 PM
> Subject: Re: [PATCH 1/2] Tracepoint API doc update: data argument
>
> On Wed, 12 Mar 2014 00:52:33 +0000 (UTC)
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>
> > ----- Original Message -----
> > > From: "Steven Rostedt" <rostedt@goodmis.org>
> > > To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> > > Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>,
> > > "Frederic Weisbecker" <fweisbec@gmail.com>,
> > > "Andrew Morton" <akpm@linux-foundation.org>
> > > Sent: Tuesday, March 11, 2014 7:34:50 PM
> > > Subject: Re: [PATCH 1/2] Tracepoint API doc update: data argument
> > >
> > > On Mon, 10 Mar 2014 21:04:57 -0400
> > > Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> > >
> > > > Describe the @data argument (probe private data).
> > > >
> > > > Fixes: 38516ab59fbc "tracing: Let tracepoints have data passed to
> > > > tracepoint callbacks"
> > > > CC: Steven Rostedt <rostedt@goodmis.org>
> > > > CC: Ingo Molnar <mingo@kernel.org>
> > > > CC: Frederic Weisbecker <fweisbec@gmail.com>
> > > > CC: Andrew Morton <akpm@linux-foundation.org>
> > >
> > > No signed-off-by.
> >
> > Hi Steven,
> >
> > I'm curious to understand the reason of this "no signed-off-by" on a
> > trivial
> > patch that fixes the missing DocBook comments for one of your previous
> > commits that has been upstream for a few years. What am I missing ?
> > Perhaps you meant this reply for my other documentation update patch (2/2)
> > ?
> >
>
> I mean, my scripts wont accept a patch that the author never added
> their signed-off-by to.
>
> In other words, resubmit, and add your own signed-off-by that happens to
> be missing from this patch.
Oh, sorry, I missed that. Will do.
Thanks,
Mathieu
>
> -- Steve
>
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-12 1:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-11 1:04 [PATCH 1/2] Tracepoint API doc update: data argument Mathieu Desnoyers
2014-03-11 1:04 ` [PATCH 2/2] Tracepoint API doc update: tracepoint_probe_register() return value Mathieu Desnoyers
2014-03-11 23:34 ` [PATCH 1/2] Tracepoint API doc update: data argument Steven Rostedt
2014-03-12 0:52 ` Mathieu Desnoyers
2014-03-12 1:14 ` Steven Rostedt
2014-03-12 1:30 ` Mathieu Desnoyers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.