All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: "Michel Dänzer" <michel@daenzer.net>
Subject: Re: [PATCH/RFC] drm: Disallow DRM_IOCTL_MODESET_CTL for KMS drivers
Date: Tue, 17 Jul 2012 17:01:38 +0200	[thread overview]
Message-ID: <10518872.AvgqqFJsiG@avalon> (raw)
In-Reply-To: <2679315.909faE8pzZ@avalon>

On Wednesday 30 May 2012 19:12:11 Laurent Pinchart wrote:
> On Wednesday 30 May 2012 13:29:06 Michel Dänzer wrote:
> > On Mit, 2012-05-30 at 00:58 +0200, Laurent Pinchart wrote:
> > > DRM_IOCTL_MODESET_CTL must only be used for UMS drivers. Make it a no-op
> > > for KMS drivers.
> > > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > 
> > >  drivers/gpu/drm/drm_irq.c |    5 ++++-
> > >  1 files changed, 4 insertions(+), 1 deletions(-)
> > > 
> > > My understanding of the DRM framework tells me that calling
> > > DRM_IOCTL_MODESET_CTL on a KMS driver is not only unneeded, but could
> > > also
> > > mess up its internal state. Did I get it right ?
> > 
> > Yes, good catch.
> > 
> > > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> > > index c798eea..03f16f3 100644
> > > --- a/drivers/gpu/drm/drm_irq.c
> > > +++ b/drivers/gpu/drm/drm_irq.c
> > > @@ -974,7 +974,6 @@ EXPORT_SYMBOL(drm_vblank_off);
> > > 
> > >   * drm_vblank_pre_modeset - account for vblanks across mode sets
> > >   * @dev: DRM device
> > >   * @crtc: CRTC in question
> > > - * @post: post or pre mode set?
> > >   *
> > >   * Account for vblank events across mode setting events, which will
> > >   likely
> > >   * reset the hardware frame counter.
> > 
> > This hunk should really be in a separate patch,
> 
> I've thought about sending a separate patch, but as the change only touched
> a single line of comment related to the same function, I ended up not
> splitting it. I can resubmit two patches if needed.

Ping ? Dave, could you take the patch in your tree ? I can split it if needed.

> > but other than that
> > 
> > Reviewed-by: Michel Dänzer <michel@daenzer.net>
> 
> Thank you.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2012-07-17 15:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-29 22:58 [PATCH/RFC] drm: Disallow DRM_IOCTL_MODESET_CTL for KMS drivers Laurent Pinchart
2012-05-30 11:29 ` Michel Dänzer
2012-05-30 17:12   ` Laurent Pinchart
2012-07-17 15:01     ` Laurent Pinchart [this message]
2012-07-17 20:06       ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10518872.AvgqqFJsiG@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=michel@daenzer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.