Re: Re: [PATCH 4/6] ARM: S3C64XX: Adds Touch Screen Driver Support for S3C6410

[NAVEEN KRISHNA CHATRADHI <ch.naveen@samsung.com>]

Hi, Maurus

------- Original Message -------
Sender : Maurus Cuelenaere<mcuelenaere@gmail.com> 
Date   : May 07, 2010 14:55 (GMT+05:00)
Title  : Re: [PATCH 4/6] ARM: S3C64XX: Adds Touch Screen Driver Support for
 S3C6410

Hi Naveen,

"Kukjin Kim" <kgene.kim@samsung.com> wrote:

>From: Naveen Krishna <ch.naveen@samsung.com>
>
>Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com>
>Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
>---
> arch/arm/mach-s3c64xx/Kconfig          |    1 +
> arch/arm/mach-s3c64xx/mach-smdk6410.c  |   12 +++++++
> arch/arm/mach-s3c64xx/s3c6410.c        |    1 +
> arch/arm/plat-samsung/Kconfig          |    5 +++
> arch/arm/plat-samsung/Makefile         |    1 +
> arch/arm/plat-samsung/dev-ts.c         |   54 ++++++++++++++++++++++++++++++++
> drivers/input/touchscreen/Kconfig      |    3 +-
> drivers/input/touchscreen/s3c2410_ts.c |   19 +++++++++--
> 8 files changed, 92 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm/plat-samsung/dev-ts.c
>

I'm sure you've seen my patch which does pretty much the same wrt adjusting s3c2410_ts.c.
Though that one has already been acked by Ben so I'm unsure what should happen: you adjusting your patchset or me dropping mine (obviously I prefer the former :) ).
My patch was under review for over a week, its a coincidence that i saw your patch and my patch was posted on mainline. 
I'ill rework my patches anyway, I'ill wait for a day on Ben Dook's Comments on my patch set.

P.S.: I'd recommend splitting this patch and sending the drivers/input part to the linux-input mailing list.
I'ill take this option.

--
Maurus Cuelenaere


Thanks & Best Regards,
Naveen Krishna Ch
SE @ SLG Div, DS LABs, Samsung, India.