From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Greg KH <greg@kroah.com>, Miles Lane <miles.lane@attbi.com>,
willy@debian.org,
linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: Looks like your PCI patch broke the PPC build (and others)?
Date: 12 Jun 2003 15:35:25 +0200 [thread overview]
Message-ID: <1055424925.604.39.camel@gaston> (raw)
In-Reply-To: <16104.10078.284006.569894@cargo.ozlabs.ibm.com>
On Thu, 2003-06-12 at 09:10, Paul Mackerras wrote:
> Greg KH writes:
>
> > Not my patch, Matthew's :)
> >
> > I think the PPC developers have a fix for this.
>
> Just #include <asm/pci-bridge.h> at the top of include/asm-ppc/pci.h.
> I'll push that change to Linus.
Well... asm/pci-bridge.h includes linux/pci.h which includes asm/pci.h,
so we have a circular include here...
What I did in my tree is to move the definition of pci_controller
from asm/pci-bridge.h to asm/pci.h. I'm now considering removing
asm/pci-bridge.h, what do you think ?
Ben.
next prev parent reply other threads:[~2003-06-12 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 19:15 Looks like your PCI patch broke the PPC build (and others)? Miles Lane
2003-06-11 20:28 ` Greg KH
2003-06-12 7:10 ` Paul Mackerras
2003-06-12 13:35 ` Benjamin Herrenschmidt [this message]
2003-06-12 22:31 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055424925.604.39.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@attbi.com \
--cc=paulus@samba.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.