From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH resend] tests: Makefile: include dependency files
Date: Tue, 24 Jul 2012 07:16:18 -0400 (EDT) [thread overview]
Message-ID: <1055514151.1144082.1343128578833.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120718172227.GC18479@otherpad.lan.raisama.net>
----- Messaggio originale -----
> Da: "Eduardo Habkost" <ehabkost@redhat.com>
> A: qemu-devel@nongnu.org
> Cc: "Paolo Bonzini" <pbonzini@redhat.com>, "Anthony Liguori" <anthony@codemonkey.ws>
> Inviato: Mercoledì, 18 luglio 2012 19:22:27
> Oggetto: [PATCH resend] tests: Makefile: include dependency files
>
> Otherwise 'make check' won't recompile files that need to be
> recompiled
> because of header changes.
>
> To reproduce the bug, run:
>
> $ make check # succeeds
> $ echo B0RKED > hw/mc146818rtc_regs.h
> $ make check # is supposed to try to rebuild tests/rtc-test.o and
> fail
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> tests/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index d66ab19..b3f7494 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -143,3 +143,5 @@ check-qtest: $(patsubst %,check-qtest-%,
> $(QTEST_TARGETS))
> check-unit: $(patsubst %,check-%, $(check-unit-y))
> check-block: $(patsubst %,check-%, $(check-block-y))
> check: check-unit check-qtest
> +
> +-include $(wildcard tests/*.d)
> --
> 1.7.10.4
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2012-07-24 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 17:22 [Qemu-devel] [PATCH resend] tests: Makefile: include dependency files Eduardo Habkost
2012-07-24 11:16 ` Paolo Bonzini [this message]
2012-07-28 12:15 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055514151.1144082.1343128578833.JavaMail.root@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.