From: James Bottomley <James.Bottomley@steeleye.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: tonyb@cybernetics.com, Marcelo Tosatti <marcelo@conectiva.com.br>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
dougg@torque.net
Subject: Re: [PATCH] 2.4.21 fix race condition in sg.c
Date: 27 Jun 2003 09:47:00 -0500 [thread overview]
Message-ID: <1056725222.2099.21.camel@mulgrave> (raw)
In-Reply-To: <1056724288.3172.43.camel@dhcp22.swansea.linux.org.uk>
On Fri, 2003-06-27 at 09:31, Alan Cox wrote:
> For cases you just have to force compiler ordering you can use barrier, which
> resolves to
>
> __asm__ __volatile__("": : :"memory")
>
> ie an empty space that affects memory so causes write backs
Right. The code in question is the only statement between an if block
and a function call, thus I believe it's safe from gcc reordering, so I
was assuming the intent was externally visible ordering (which can be
the expensive one).
James
next prev parent reply other threads:[~2003-06-27 14:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-27 13:52 [PATCH] 2.4.21 fix race condition in sg.c Tony Battersby
2003-06-27 14:10 ` James Bottomley
2003-06-27 14:31 ` Alan Cox
2003-06-27 14:47 ` James Bottomley [this message]
2003-06-27 14:57 ` Tony Battersby
2003-06-27 15:00 ` Jeff Garzik
2003-06-27 15:11 ` James Bottomley
2003-06-27 15:38 ` Tony Battersby
-- strict thread matches above, loose matches on Subject: below --
2003-06-26 15:18 Tony Battersby
2003-06-26 22:15 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1056725222.2099.21.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=tonyb@cybernetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.