All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@rvs.uni-bielefeld.de>
To: James Courtier-Dutton <James@superbug.demon.co.uk>
Cc: Cozza <ac2crp@blueyonder.co.uk>,
	bluez Dev <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] Bluetooth headset problems.
Date: 06 Jul 2003 22:44:02 +0200	[thread overview]
Message-ID: <1057524249.6946.83.camel@pegasus> (raw)
In-Reply-To: <3F08719F.70708@superbug.demon.co.uk>

Hi James,

> If anyone is interested, the fix for recording required 2 urbs for each 
> isoc connection. The current cvs only uses 1 urb for isoc connections, 
> so the usbcore fills one urb in real time, and then when it is full, 
> sends it to hci_usb.c via a callback. Once hci_usb.c has finished with 
> the urb it sends it back to the usbcore to get refilled. The problem is 
> that while hci_usb.c is processing the urb, usbcore has no urb to put 
> real time audio samples in, so it just drops them. If 2 urbs are used, 
> if hci_usb.c is processing one, usbcore always has another to place 
> samples in. As long as hci_usb.c does not hold on to it's urb for too 
> long, all is ok. This fix was discovered by comparing the alsa 
> snd-usb-audio driver with the hci_usb.c driver.

this sounds reasonable to me. Currently I have replaced the ZERO_PACKET
compile option with a module parameter, which allows you to change this
easily at runtime. I will push this together with a new driver for a non
H2 compatible USB device.

It is also a good idea to remove the SCO compile option, because it is
not really needed and we can safely enable SCO for all H2 devies with
ISOC endpoints. If you are working on a patch for full SCO support,
please take care of this.

Regards

Marcel




-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2003-07-06 20:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-02 13:18 [Bluez-devel] Bluetooth headset problems James Courtier-Dutton
2003-07-03 11:05 ` Cozza
2003-07-03 12:36   ` James Courtier-Dutton
2003-07-05  1:55   ` James Courtier-Dutton
2003-07-06 18:59     ` James Courtier-Dutton
2003-07-06 20:44       ` Marcel Holtmann [this message]
2003-07-06 22:11         ` James Courtier-Dutton
2003-07-06 22:16           ` Marcel Holtmann
2003-07-08  9:13             ` Cozza
2003-07-09 10:06               ` David Woodhouse
2003-07-21 22:30       ` Max Krasnyansky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1057524249.6946.83.camel@pegasus \
    --to=marcel@rvs.uni-bielefeld.de \
    --cc=James@superbug.demon.co.uk \
    --cc=ac2crp@blueyonder.co.uk \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.