From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Wed, 19 Oct 2016 11:37:11 -0400 (EDT) Subject: [Cluster-devel] [DLM PATCH] DLM: Don't save callbacks after accept In-Reply-To: <418069748.3262986.1474655006158.JavaMail.zimbra@redhat.com> References: <418069748.3262986.1474655006158.JavaMail.zimbra@redhat.com> Message-ID: <1058410649.9549156.1476891431289.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | Hi, | | When DLM calls accept() on a socket, the comm code copies the sk | after we've saved its callbacks. Afterward, it calls add_sock which | saves the callbacks a second time. Since the error reporting function | lowcomms_error_report calls the previous callback too, this results | in a recursive call to itself. This patch adds a new parameter to | function add_sock to tell whether to save the callbacks. Function | tcp_accept_from_sock (and its sctp counterpart) then calls it with | false to avoid the recursion. | | Signed-off-by: Bob Peterson | --- Hi Dave, Any word on this patch from 23 September? Regards, Bob Peterson Red Hat File Systems