From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 3/4] arm64: dts: rockchip: add rx0 mipi-phy for rk3399 Date: Thu, 02 Apr 2020 16:31:11 +0200 Message-ID: <105956984.FXDh2DO4ZE@diego> References: <20200402000234.226466-4-helen.koike@collabora.com> <970b9e48-e38f-7e7a-3472-7dc5a4737e58@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <970b9e48-e38f-7e7a-3472-7dc5a4737e58@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Johan Jonker Cc: helen.koike@collabora.com, dafna.hirschfeld@collabora.com, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, ezequiel@collabora.com, hverkuil-cisco@xs4all.nl, karthik.poduval@gmail.com, kernel@collabora.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, mark.rutland@arm.com, robh+dt@kernel.org List-Id: linux-rockchip.vger.kernel.org Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker: > Hi Helen, > > > From: Helen Koike > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > index 33cc21fcf4c10..fc0295d2a65a1 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > @@ -1394,6 +1394,17 @@ io_domains: io-domains { > > status = "disabled"; > > }; > > > > > + mipi_dphy_rx0: mipi-dphy-rx0 { > > For Heiko sort syscon@ff770000 subnodes alphabetical or reg value first? Similar to main nodes ... so things without reg alphabetical, the rest by reg address > > > + compatible = "rockchip,rk3399-mipi-dphy-rx0"; > > + clocks = <&cru SCLK_MIPIDPHY_REF>, > > > + <&cru SCLK_DPHY_RX0_CFG>, > > + <&cru PCLK_VIO_GRF>; > > Align ^ > > > + clock-names = "dphy-ref", "dphy-cfg", "grf"; > > + power-domains = <&power RK3399_PD_VIO>; > > + #phy-cells = <0>; > > + status = "disabled"; > > + }; > > + > > u2phy0: usb2-phy@e450 { > > compatible = "rockchip,rk3399-usb2phy"; > > reg = <0xe450 0x10>; > >