All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: Joel Soete <jsoe0708@tiscali.be>
Cc: parisc-linux@parisc-linux.org
Subject: Re: [parisc-linux] backport bitops.h stuff
Date: 01 Aug 2003 10:59:02 -0500	[thread overview]
Message-ID: <1059753543.2092.30.camel@mulgrave> (raw)
In-Reply-To: <3F29178A000004C6@ocpmta7.freegates.net>

On Fri, 2003-08-01 at 10:28, Joel Soete wrote:
> Can somebody help me to ci inot 2.4 this patch which backport ffs() needed
> for new devmapper ;)

Actually, this patch looks decidedly non-optimal.

See include/linux/bitops.h:generic_ffs for how it should be done on
architectures that don't have any machine instruction help.  That's only
four if statements and no loop.

I see we already have the loop thing in 2.5, but should we consider
simply using the generic operations there as well?

even for __ffs, which is just a slight optimisation over ffs, using
generic_ffs would probably be faster

James

  parent reply	other threads:[~2003-08-01 15:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-01 15:28 [parisc-linux] backport bitops.h stuff Joel Soete
2003-08-01 15:35 ` Joel Soete
2003-08-01 15:59 ` James Bottomley [this message]
2003-08-01 17:09   ` Joel Soete
2003-08-01 17:14     ` LaMont Jones
2003-08-01 17:25       ` Joel Soete
2003-08-01 17:33       ` James Bottomley
2003-08-04 10:43       ` Joel Soete
2003-08-04 15:14         ` LaMont Jones
2003-08-04 16:08           ` James Bottomley
2003-08-04 17:04             ` Joel Soete
2003-08-04 16:53           ` Joel Soete

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1059753543.2092.30.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=jsoe0708@tiscali.be \
    --cc=parisc-linux@parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.