From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Dmitrii Dolgov <9erthalion6@gmail.com>,
io-uring@vger.kernel.org
Subject: Re: [RFC] Check if file_data is initialized
Date: Thu, 9 Jan 2020 08:34:28 -0700 [thread overview]
Message-ID: <105a9991-2c04-d2d3-cc8c-8ffa6ae3529f@kernel.dk> (raw)
In-Reply-To: <73e00d5c-e36e-6614-9de1-19978efd7e61@gmail.com>
On 1/9/20 8:17 AM, Pavel Begunkov wrote:
>> diff --git a/fs/io_uring.c b/fs/io_uring.c
>> index 32aee149f652..b5dcf6c800ef 100644
>> --- a/fs/io_uring.c
>> +++ b/fs/io_uring.c
>> @@ -1218,6 +1218,8 @@ struct req_batch {
>>
>> static void io_free_req_many(struct io_ring_ctx *ctx, struct req_batch *rb)
>> {
>> + int fixed_refs = 0;
>> +
>
> If all are fixed, then @rb->need_iter == false (see
> io_req_multi_free()), and @fixed_refs will be left 0. How about to set
> it to rb->to_free, and zero+count for rb->need_iter == true?
Good catch, I'll make that change.
--
Jens Axboe
next prev parent reply other threads:[~2020-01-09 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 13:17 [RFC] Check if file_data is initialized Dmitrii Dolgov
2020-01-09 14:26 ` Pavel Begunkov
2020-01-09 14:51 ` Jens Axboe
2020-01-09 15:17 ` Pavel Begunkov
2020-01-09 15:23 ` Jens Axboe
2020-01-09 15:32 ` Pavel Begunkov
2020-01-09 15:34 ` Jens Axboe [this message]
2020-01-09 16:04 ` Dmitry Dolgov
2020-01-09 16:19 ` Jens Axboe
2020-01-09 14:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=105a9991-2c04-d2d3-cc8c-8ffa6ae3529f@kernel.dk \
--to=axboe@kernel.dk \
--cc=9erthalion6@gmail.com \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.