From: Alisa-Dariana Roman <alisadariana@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
michael.hennerich@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: alexandru.tachici@analog.com, lars@metafoo.de, jic23@kernel.org,
robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com,
bigunclemax@gmail.com, dlechner@baylibre.com,
okan.sahin@analog.com, fr0st61te@gmail.com,
alisa.roman@analog.com, marcus.folkesson@gmail.com,
schnelle@linux.ibm.com, liambeguin@gmail.com
Subject: Re: [PATCH v5 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support
Date: Mon, 15 Apr 2024 16:08:00 +0300 [thread overview]
Message-ID: <105bd25b-e5ea-4649-b9b2-2547e94b103e@gmail.com> (raw)
In-Reply-To: <2ad06ea8-220f-4d09-bbe7-c4dd12d0d8bd@linaro.org>
On 14.04.2024 00:19, Krzysztof Kozlowski wrote:
> On 13/04/2024 17:11, Alisa-Dariana Roman wrote:
>> Unlike the other AD719Xs, AD7194 has configurable differential
>> channels. The user can dynamically configure them in the devicetree.
>>
>> Also add an example for AD7194 devicetree.
>>
>> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
>> ---
>> .../bindings/iio/adc/adi,ad7192.yaml | 74 +++++++++++++++++++
>> 1 file changed, 74 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
>> index ba506af3b73e..855f0a2d7d75 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
...
>
>> + "^channel@[0-9]+$":
>
> Why restricting the pattern? If you have 256 channels, how are you going
> to encode it?
Hi Krzysztof,
Thank you for your feedback! I applied the rest, but as for this one
isn't channel@1 -> channel@256 encoding sufficient?
Kind regards,
Alisa-Dariana Roman
next prev parent reply other threads:[~2024-04-15 13:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 15:11 [PATCH v5 0/5] iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-04-13 15:11 ` [PATCH v5 1/5] iio: adc: ad7192: Use standard attribute Alisa-Dariana Roman
2024-04-13 20:31 ` David Lechner
2024-04-13 15:11 ` [PATCH v5 2/5] dt-bindings: iio: adc: ad7192: Add aincom supply Alisa-Dariana Roman
2024-04-13 18:05 ` David Lechner
2024-04-13 15:11 ` [PATCH v5 3/5] " Alisa-Dariana Roman
2024-04-13 17:26 ` Jonathan Cameron
2024-04-13 19:10 ` David Lechner
2024-04-14 13:58 ` Alisa-Dariana Roman
2024-04-14 20:20 ` David Lechner
2024-04-13 15:11 ` [PATCH v5 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-04-13 19:29 ` David Lechner
2024-04-14 20:31 ` Alisa-Dariana Roman
2024-04-13 21:19 ` Krzysztof Kozlowski
2024-04-15 13:08 ` Alisa-Dariana Roman [this message]
2024-04-15 13:55 ` David Lechner
2024-04-17 23:38 ` Krzysztof Kozlowski
2024-04-13 15:11 ` [PATCH v5 5/5] " Alisa-Dariana Roman
2024-04-13 17:29 ` Jonathan Cameron
2024-04-13 20:05 ` David Lechner
2024-04-14 20:14 ` Alisa-Dariana Roman
2024-04-14 20:24 ` David Lechner
2024-04-15 13:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=105bd25b-e5ea-4649-b9b2-2547e94b103e@gmail.com \
--to=alisadariana@gmail.com \
--cc=alexandru.tachici@analog.com \
--cc=alisa.roman@analog.com \
--cc=andy@kernel.org \
--cc=bigunclemax@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=fr0st61te@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=okan.sahin@analog.com \
--cc=robh@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.