From mboxrd@z Thu Jan 1 00:00:00 1970 From: NeilBrown Subject: [PATCH 002 of 16] knfsd: nfsd4: Wrong error handling in nfs4acl Date: Mon, 3 Apr 2006 15:18:11 +1000 Message-ID: <1060403051811.1739@suse.de> References: <20060403151452.1567.patches@notabene> Cc: nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: To: Andrew Morton Sender: linux-kernel-owner@vger.kernel.org List-ID: this fixes coverity id #3. Coverity detected dead code, since the == -1 comparison only returns 0 or 1 to error. Therefore the if ( error < 0 ) statement was always false. Seems that this was an if( error = nfs4... ) statement some time ago, which got broken during cleanup. Signed-off-by: Eric Sesterhenn Signed-off-by: J. Bruce Fields Signed-off-by: Neil Brown ### Diffstat output ./fs/nfsd/nfs4acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff ./fs/nfsd/nfs4acl.c~current~ ./fs/nfsd/nfs4acl.c --- ./fs/nfsd/nfs4acl.c~current~ 2006-04-03 15:12:05.000000000 +1000 +++ ./fs/nfsd/nfs4acl.c 2006-04-03 15:12:05.000000000 +1000 @@ -790,7 +790,7 @@ nfs4_acl_split(struct nfs4_acl *acl, str continue; error = nfs4_acl_add_ace(dacl, ace->type, ace->flag, - ace->access_mask, ace->whotype, ace->who) == -1; + ace->access_mask, ace->whotype, ace->who); if (error < 0) goto out;