From: NeilBrown <neilb@suse.de>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Olaf Kirch <okir@suse.de>, Chuck Lever <chuck.lever@oracle.com>,
nfs@lists.sourceforge.net
Subject: [PATCH 002 of 4] Make the initial RPC PING interruptible.
Date: Tue, 24 Oct 2006 12:48:57 +1000 [thread overview]
Message-ID: <1061024024857.4748@suse.de> (raw)
In-Reply-To: 20061024122646.4426.patches@notabene
If an RPC client is created with CREATE_INTR and not CREATE_NOPING,
then the ping should be interruptible. With tcp the PING can take 30
seconds to time out and not being able to interrupt that can be
frustrating.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./net/sunrpc/clnt.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff .prev/net/sunrpc/clnt.c ./net/sunrpc/clnt.c
--- .prev/net/sunrpc/clnt.c 2006-10-24 09:41:49.000000000 +1000
+++ ./net/sunrpc/clnt.c 2006-10-24 09:43:48.000000000 +1000
@@ -221,7 +221,15 @@ struct rpc_clnt *rpc_create(struct rpc_c
return clnt;
if (!(args->flags & RPC_CLNT_CREATE_NOPING)) {
- int err = rpc_ping(clnt, RPC_TASK_SOFT|RPC_TASK_NOINTR);
+ int tskflags = RPC_TASK_SOFT;
+ int err;
+ if ( ! (args->flags & RPC_CLNT_CREATE_INTR))
+ tskflags |= RPC_TASK_NOINTR;
+ /* Note: we keep task_soft even if RPC_CLNT_CREATE_HARDRTRY
+ * is set. The whole point of the PING is to check that the
+ * server is there *now*
+ */
+ err = rpc_ping(clnt, tskflags);
if (err != 0) {
rpc_shutdown_client(clnt);
return ERR_PTR(err);
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2006-10-24 2:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 2:48 [PATCH 000 of 4] Introduction Possibly patches for RPC client changes NeilBrown
2006-10-24 2:48 ` [PATCH 001 of 4] Copy intr and soft flags to portmap-bind client NeilBrown
2006-10-24 23:05 ` Chuck Lever
2006-11-15 17:11 ` Trond Myklebust
2006-11-15 19:38 ` Chuck Lever
2006-11-15 20:31 ` Trond Myklebust
2006-11-15 21:14 ` Chuck Lever
2006-11-16 3:27 ` Neil Brown
2006-10-24 2:48 ` NeilBrown [this message]
2006-10-24 23:19 ` [PATCH 002 of 4] Make the initial RPC PING interruptible Chuck Lever
2006-11-16 3:22 ` Neil Brown
2006-10-24 2:49 ` [PATCH 003 of 4] Make RPC 'ping' requests fail more quickly NeilBrown
2006-10-24 23:37 ` Chuck Lever
2006-11-15 17:14 ` Trond Myklebust
2006-11-16 3:20 ` Neil Brown
2006-10-24 2:49 ` [PATCH 004 of 4] Inherit soft/intr flags from NFS mount to lockd requests NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1061024024857.4748@suse.de \
--to=neilb@suse.de \
--cc=chuck.lever@oracle.com \
--cc=nfs@lists.sourceforge.net \
--cc=okir@suse.de \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.