From mboxrd@z Thu Jan 1 00:00:00 1970 From: NeilBrown Subject: [PATCH 010 of 18] knfsd: nfsd4: remove spurious replay_owner check Date: Fri, 8 Dec 2006 12:14:13 +1100 Message-ID: <1061208011413.30677@suse.de> References: <20061208120939.30428.patches@notabene> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1GsUJN-00039H-VA for nfs@lists.sourceforge.net; Thu, 07 Dec 2006 17:14:02 -0800 Received: from mx1.suse.de ([195.135.220.2]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1GsUJO-00052C-RR for nfs@lists.sourceforge.net; Thu, 07 Dec 2006 17:14:03 -0800 To: Andrew Morton List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net From: J.Bruce Fields OK, this is embarassing--I've even looked back at the history, and cannot for the life of me figure out why I added this check. Signed-off-by: J. Bruce Fields Signed-off-by: Neil Brown ### Diffstat output ./fs/nfsd/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff .prev/fs/nfsd/nfs4proc.c ./fs/nfsd/nfs4proc.c --- .prev/fs/nfsd/nfs4proc.c 2006-12-08 12:09:27.000000000 +1100 +++ ./fs/nfsd/nfs4proc.c 2006-12-08 12:09:27.000000000 +1100 @@ -1008,7 +1008,7 @@ encode_op: nfsd4_encode_operation(resp, op); status = op->status; } - if (replay_owner && (replay_owner != (void *)(-1))) { + if (replay_owner) { nfs4_put_stateowner(replay_owner); replay_owner = NULL; } ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164353AbWLHBOp (ORCPT ); Thu, 7 Dec 2006 20:14:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1164322AbWLHBOi (ORCPT ); Thu, 7 Dec 2006 20:14:38 -0500 Received: from mail.suse.de ([195.135.220.2]:58487 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164338AbWLHBOC (ORCPT ); Thu, 7 Dec 2006 20:14:02 -0500 From: NeilBrown To: Andrew Morton Date: Fri, 8 Dec 2006 12:14:13 +1100 Message-Id: <1061208011413.30677@suse.de> X-face: [Gw_3E*Gng}4rRrKRYotwlE?.2|**#s9D Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: J.Bruce Fields OK, this is embarassing--I've even looked back at the history, and cannot for the life of me figure out why I added this check. Signed-off-by: J. Bruce Fields Signed-off-by: Neil Brown ### Diffstat output ./fs/nfsd/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff .prev/fs/nfsd/nfs4proc.c ./fs/nfsd/nfs4proc.c --- .prev/fs/nfsd/nfs4proc.c 2006-12-08 12:09:27.000000000 +1100 +++ ./fs/nfsd/nfs4proc.c 2006-12-08 12:09:27.000000000 +1100 @@ -1008,7 +1008,7 @@ encode_op: nfsd4_encode_operation(resp, op); status = op->status; } - if (replay_owner && (replay_owner != (void *)(-1))) { + if (replay_owner) { nfs4_put_stateowner(replay_owner); replay_owner = NULL; }