From: Ronald Bultje <rbultje@ronald.bitfreak.net>
To: Trivial Patch Monkey <trivial@rustcorp.com.au>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] 2.6.0-test4: small updates for zoran driver
Date: 24 Aug 2003 02:13:21 +0200 [thread overview]
Message-ID: <1061684001.4302.249.camel@localhost.localdomain> (raw)
Hey,
I've got 6 small patches to fix various small issues noticed by people
with the zoran driver that was accepted in 2.6.0-test3. These patches
should fix some of these issues. Most were noticed by Francois Romieu
(#1, #4-6). #2 was noticed by Linus (symbol conflict), #3 was already
announced by Gerd Knorr (v4l maitainer) some time ago, but I forgot to
actually apply the fix for that to my driver.
#1 fixes several memleaks in error cases when the setup of i2c client
drivers for video encoders/decoders fails. We forgot to free some memory
in various places.
#2 renames debug to zr_debug because debug is already defined somewhere
else.
#3 adds a release callback which frees the video_device struct. This is
needed to prevent freeing memoy before it's not in use anymore, as
described in http://lwn.net/Articles/36850/. Without this, the driver
will give a warning when loaded.
#4 adds pci_disable_device() to the card release function, we already
used pci_enable_device() in the card detection function.
#5 changes some funky coding style (a.k.a. indent artifact) to a
somewhat more conservative coding style.
#6 adds some newlines between variable declarations and function bodies.
1: http://213.197.11.65/ronald/patches/20030821_memleak_fixes.diff
2: http://213.197.11.65/ronald/patches/20030822_debug.diff
3: http://213.197.11.65/ronald/patches/20030821_vdf_release.diff
4: http://213.197.11.65/ronald/patches/20030823_disable_device.diff
5: http://213.197.11.65/ronald/patches/20030821_indenting.diff
6: http://213.197.11.65/ronald/patches/20030821_whitespace.diff
Please apply all of them.
On a related note, I'm not trying to be a pain in the ass by not
inlining patches, but Evolution doesn't seem to like me doing that, so
I'm kind of forced to do it differently. Is anyone else here using
Evolution to send in patches or is Evolution broken?
Thanks,
Ronald
--
Ronald Bultje <rbultje@ronald.bitfreak.net>
next reply other threads:[~2003-08-23 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-24 0:13 Ronald Bultje [this message]
2003-08-24 3:29 ` [PATCH] 2.6.0-test4: small updates for zoran driver Andrew Morton
2003-08-24 4:33 ` Ronald Bultje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1061684001.4302.249.camel@localhost.localdomain \
--to=rbultje@ronald.bitfreak.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.