From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] fallocate05: increase FALLOCATE_SIZE
Date: Tue, 19 Nov 2019 05:02:34 -0500 (EST) [thread overview]
Message-ID: <1061994684.12955452.1574157754643.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <6371c082-ac3a-3daf-9196-481973f85b04@suse.cz>
----- Original Message -----
> > ----- Original Message -----
> > fallocate05 seems to be the only test using it, but in general I think we
> > can do that too. Assuming this alone would be reliable, is there any
> > advantage of running test with small FALLOCATE_SIZE?
>
> Note that simply increasing FALLOCATE_SIZE will not fix an incorrect
> pass when the file system wasn't completely full. Here's the code that
> checks whether some blocks were properly fallocate()d:
>
> tst_fill_fs(MNTPOINT, 1);
> ret = write(fd, buf, sizeof(buf));
> if (ret < 0)
> tst_res(TFAIL | TERRNO, "write() failed unexpectedly");
> else
> tst_res(TPASS, "write() wrote %zu bytes", ret);
>
> If the file system somehow finds a few free blocks after tst_fill_fs()
> returns, short write() will still count as a pass.
That is good point, but that seems like issue that existed even with
8k FALLOCATE_SIZE, right?
prev parent reply other threads:[~2019-11-19 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 16:08 [LTP] [PATCH] fallocate05: increase FALLOCATE_SIZE Jan Stancek
2019-11-18 16:18 ` Martin Doucha
2019-11-19 5:45 ` Li Wang
2019-11-18 16:19 ` Cyril Hrubis
2019-11-19 5:34 ` Li Wang
2019-11-19 8:13 ` Jan Stancek
2019-11-19 8:59 ` Li Wang
2019-11-19 9:47 ` Martin Doucha
2019-11-19 10:02 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1061994684.12955452.1574157754643.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.