From: James Bottomley <James.Bottomley@steeleye.com>
To: Andrew Morton <akpm@osdl.org>
Cc: wli@holomorphy.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make voyager work again after the cpumask_t changes
Date: 28 Aug 2003 15:37:17 -0400 [thread overview]
Message-ID: <1062099437.1952.45.camel@mulgrave> (raw)
In-Reply-To: <20030828121016.2c0e2716.akpm@osdl.org>
On Thu, 2003-08-28 at 15:10, Andrew Morton wrote:
> Yes, the generic code was like that too. It was causing lockups. Sorry, I
> did not realise that voyager had a private invalidatation implementation.
It actually has to since the invalidation implementation is a property
of the SMP HAL...fortunately voyager is the only subarch that has to
replace the SMP HAL wholesale.
> Officially smp_invalidate_needed should be a cpumask_t and
> smp_invalidate_interrupt() should be using cpu_isset() rather than
> open-coded bitops. For all those 64-way voyagers out there ;)
>
> (Actually it is legitimate: you may want to run a NR_CPUS=48 kernel on a
> 2-way voyager just for testing purposes). I'll drop your patch in as-is,
> and maybe Bill can take a look at cpumaskifying it sometime?
OK.
Actually, looking at the code made me realise that we can kill the
tlbstate_lock and run lockless, so I'll play with doing that too.
James
next prev parent reply other threads:[~2003-08-28 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-28 19:02 [PATCH] make voyager work again after the cpumask_t changes James Bottomley
2003-08-28 19:10 ` Andrew Morton
2003-08-28 19:31 ` William Lee Irwin III
2003-08-28 19:20 ` Andrew Morton
2003-08-28 19:40 ` William Lee Irwin III
2003-08-28 19:37 ` James Bottomley [this message]
2003-08-28 19:16 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1062099437.1952.45.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.