From: MAtias Alejo Garcia <kernel@matiu.com.ar>
To: B.Zolnierkiewicz@elka.pw.edu.pl
Cc: Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] ide_cs w/TCQ
Date: 04 Sep 2003 17:27:03 -0400 [thread overview]
Message-ID: <1062710823.1794.30.camel@runner> (raw)
Hi Bart,
I reported I problem (Unable to handle kernel NULL pointer...) when
inserting a CF card in a PCMCIA adapter in 2.6.0test1. The problem
continues in test4 (log below, when inserting a card).
The problem only is present when BLK_DEV_TCQ_DEFAULT is enabled. It
seems that ide_cs (or ide, don't know) does not correctly initialize
hwif->ide_dma_queued_on() ...I don't know how this should be fixed if
the driver doesn't use DMA:
1) Not calling ide_dma_queued_on
or
2) Initializind ide_dma_queued_on to a dummy function
I tried 1) and it works...
Here is the patch...be gentle is my first contribution :-)
Thanks!
matias
--
matías <-> http://matiu.com.ar
--- linux-2.6.0-test4/drivers/ide/ide-disk.c.orig 2003-09-04
16:45:40.000000000 -0400
+++ linux-2.6.0-test4/drivers/ide/ide-disk.c 2003-09-04
15:41:25.000000000 -0400
@@ -1689,6 +1689,7 @@
write_cache(drive, (id->cfs_enable_2 & 0x3000));
#ifdef CONFIG_BLK_DEV_IDE_TCQ_DEFAULT
+ if (drive->using_dma)
HWIF(drive)->ide_dma_queued_on(drive);
#endif
}
-----------
Sep 4 05:01:28 runner cardmgr[793]: socket 0: ATA/IDE Fixed Disk
Sep 4 05:01:28 runner cardmgr[793]: executing: 'modprobe ide-cs'
Sep 4 05:01:31 runner kernel: hde: SanDisk SDCFB-32, CFA DISK drive
Sep 4 05:01:31 runner kernel: ide2 at 0x140-0x147,0x14e on irq 5
Sep 4 05:01:31 runner kernel: hde: max request size: 128KiB
Sep 4 05:01:31 runner kernel: hde: 62720 sectors (32 MB) w/1KiB Cache,
CHS=490/4/32
Sep 4 05:01:31 runner kernel: Unable to handle kernel NULL pointer
dereference at virtual address 00000000
Sep 4 05:01:31 runner kernel: printing
eip: Sep 4 05:01:31 runner kernel:
00000000
Sep 4 05:01:31 runner kernel: *pde = 00000000
Sep 4 05:01:31 runner kernel: Oops: 0000 [#1]
Sep 4 05:01:31 runner kernel: CPU: 0
Sep 4 05:01:31 runner kernel: EIP: 0060:[<00000000>] Tainted:
P Sep 4 05:01:31 runner kernel: EFLAGS: 00010246
Sep 4 05:01:31 runner kernel: EIP is at
0x0 Sep 4 05:01:31 runner kernel:
eax: c0427668 ebx: 00000020 ecx: de365400 edx:
00000000 Sep 4 05:01:31 runner kernel: esi: c0427714 edi: 0000f500 ebp: 00000000 esp: dbaf55a0
Sep 4 05:01:31 runner kernel: ds: 007b es: 007b ss:
0068 Sep 4 05:01:31 runner kernel: Process cardmgr
(pid: 793, threadinfo=dbaf4000 task=dbdaac80)
Sep 4 05:01:31 runner kernel: Stack: c024eb95 c0427714 000001ea
00000004 00000020 00000020 00000000 0000f500
Sep 4 05:01:31 runner kernel: 04000000 de365400 c0427714
c03b2844 dbaf4000 dfb82280 c024efa4 c0427714
Sep 4 05:01:31 runner kernel: c03b2780 00000001 00000001
c03b2844 dbaf4000 c03b2780 c024aa22 c0427714
Sep 4 05:01:32 runner kernel: Call
Trace: Sep 4 05:01:32 runner
kernel: [<c024eb95>] idedisk_setup+0x33b/0x412
Sep 4 05:01:32 runner kernel: [<c024efa4>]
idedisk_attach+0xae/0x1a4 Sep 4 05:01:32 runner kernel:
[<c024aa22>] ata_attach+0x96/0x1b2
Sep 4 05:01:32 runner kernel: [<c02446c4>]
ideprobe_init+0xe0/0xfc Sep 4 05:01:32 runner kernel:
[<c0248ec3>] ide_probe_module+0xd/0x10
Sep 4 05:01:32 runner kernel: [<c0249cbb>] ide_register_hw+0x155/0x186
Sep 4 05:01:32 runner kernel: [<e0845224>] idecs_register+0x5e/0x70
[ide_cs]
[bla bla bla]
Sep 4 05:01:33 runner kernel: Code: Bad EIP value.
next reply other threads:[~2003-09-04 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-04 21:27 MAtias Alejo Garcia [this message]
2003-09-04 21:04 ` [PATCH] ide_cs w/TCQ Bartlomiej Zolnierkiewicz
2003-09-05 1:21 ` Matias Alejo Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1062710823.1794.30.camel@runner \
--to=kernel@matiu.com.ar \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.