All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robert T. Johnson" <rtjohnso@eecs.berkeley.edu>
To: Corey Minyard <cminyard@mvista.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.0-test6: more __init bugs
Date: 30 Sep 2003 17:02:03 -0700	[thread overview]
Message-ID: <1064966523.5734.246.camel@dooby.cs.berkeley.edu> (raw)
In-Reply-To: <3F795001.9020104@mvista.com>

On Tue, 2003-09-30 at 02:42, Corey Minyard wrote:
> This is not actually a bug, but it may be bad style (and thus could lead 
> to a bug).  It is possible that something that uses IPMI can do some 
> IPMI things before IPMI is initialized.  This can only happen during 
> initialization, though.  Thus the check; once IPMI is initialized the 
> function will never be called.
> 
> What's the opinion on this?  Should I just force IPMI users to 
> initialize after IPMI?

Thanks for looking at it.  Would it be reasonable to fail if a client
tries to use the ipmi interface before it is initialized?  That would be
a simple change, e.g.:

if (!initialized)
       return -ENODEV;

Best,
Rob



      reply	other threads:[~2003-10-01  0:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-30 20:59 2.6.0-test6: more __init bugs Robert T. Johnson
2003-09-30  9:42 ` Corey Minyard
2003-10-01  0:02   ` Robert T. Johnson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1064966523.5734.246.camel@dooby.cs.berkeley.edu \
    --to=rtjohnso@eecs.berkeley.edu \
    --cc=cminyard@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.