From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: linuxppc-dev list <linuxppc-dev@lists.linuxppc.org>
Subject: Re: [PATCH/RFC] add proc_dir_entry fields to device_node
Date: Sat, 04 Oct 2003 09:55:50 +0200 [thread overview]
Message-ID: <1065254150.645.16.camel@gaston> (raw)
In-Reply-To: <3F7DA229.7090409@austin.ibm.com>
On Fri, 2003-10-03 at 18:22, Nathan Lynch wrote:
> Hi-
>
> I am doing some ppc64 work to enable dynamic addition and removal of
> nodes in /proc/device-tree. It seems that recording a node's directory
> and symlinks (if any) in the device_node is the easiest way to assure
> that a node is cleaned up properly after deletion.
>
> I need to add a few lines to fs/proc/proc_devtree.c::add_node() to
> record the proc entries for each node as it is processed. These will
> refer to fields that do not yet exist in ppc's device_node. I propose
> adding these fields to ppc's device_node (patch attached). If that
> comment in prom.h about breaking BootX is still valid, there are
> alternatives, but they would likely involve ifdefs and macros.
The comment is valid. You cannot change the format of struct
device_node on ppc32 without breaking BootX booting :(
The solution to this is to finally break it by having a conversion
step between the BootX-passed device-tree and the in-kernel one
Ben
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-10-04 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-03 16:22 [PATCH/RFC] add proc_dir_entry fields to device_node Nathan Lynch
2003-10-04 7:55 ` Benjamin Herrenschmidt [this message]
2003-10-06 19:12 ` Nathan Lynch
2003-10-06 19:40 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1065254150.645.16.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=nathanl@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.