From: Matt_Domsch@Dell.com
To: hugh@veritas.com
Cc: riel@redhat.com, marcelo.tosatti@cyclades.com,
linux-kernel@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH] page->flags corruption fix
Date: Wed, 8 Oct 2003 10:31:29 -0500 [thread overview]
Message-ID: <1065627088.21242.32.camel@localhost.localdomain> (raw)
On Wed, 2003-10-08 at 09:49, Hugh Dickins wrote:
> On Tue, 7 Oct 2003, Rik van Riel wrote:
>
> > In the "better safe than sorry" category. Thanks go out to
> > Matt Domsch and Robert Hentosh. A similar fix went into the
> > 2.6 kernel. Please apply.
>
> Seven atomic ops in a row, isn't that rather inefficient?
Not all arches have atomic_set_mask() and atomic_clear_mask().
asm-arm
asm-arm26
asm-h8300
asm-i386
asm-m68k
asm-m68knommu
asm-ppc
asm-s390
asm-sh
asm-v850
asm-x86_64
do.
> The 2.6 version clears those PG_flags all together in one
> non-atomic op - but elsewhere, in prep_new_page.
>
> Is there an actual test case for why 2.4 now needs this change?
There definitely is when RMAP is present - we've reproduced it
repeatedly in our labs.
We've seen a similar failure with the RHEL2.1 kernel w/o RMAP patches
too. So we fully believe it's possible in stock 2.4.x.
Thanks,
Matt
--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
next reply other threads:[~2003-10-08 15:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 15:31 Matt_Domsch [this message]
2003-10-08 15:53 ` [PATCH] page->flags corruption fix Hugh Dickins
2003-10-08 15:59 ` Rik van Riel
2003-10-08 17:15 ` Hugh Dickins
2003-10-08 17:41 ` Marcelo Tosatti
2003-10-08 17:52 ` Rik van Riel
2003-10-11 13:48 ` Andrea Arcangeli
2003-10-11 16:03 ` Andrea Arcangeli
2003-10-12 11:15 ` Hugh Dickins
2003-10-12 13:21 ` Andrea Arcangeli
2003-10-12 13:35 ` Andrea Arcangeli
2003-10-12 14:11 ` Rik van Riel
2003-10-12 14:36 ` Andrea Arcangeli
2003-10-12 17:20 ` Rik van Riel
2003-10-12 20:40 ` Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2003-10-07 16:26 Rik van Riel
2003-10-08 14:49 ` Hugh Dickins
2003-10-08 14:57 ` David S. Miller
2003-10-08 15:10 ` Rik van Riel
2003-10-08 15:47 ` Hugh Dickins
2003-10-08 15:52 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1065627088.21242.32.camel@localhost.localdomain \
--to=matt_domsch@dell.com \
--cc=benh@kernel.crashing.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.